Catch stray Retains() and Releases() outside of RetainPtr<>.

Catch stray Retains() and Releases() outside of RetainPtr<>.

The previous CLs made the code clean, so now we can mark more things
private, and add friends as appropriate.

Committed: https://pdfium.googlesource.com/pdfium/+/cd5e12a9ea397b48056643a7b65126395eec3174

[Tom Sepez, 2016-12-07 21:06:15]

Description was changed from

==========
Catch stray Retains() and Releases() outside of RetainPtr<>.

Make more things private, and add friends as appropriate.
==========

to

==========
Catch stray Retains() and Releases() outside of RetainPtr<>.

The previous CLs made the code clean, so now we can mark more things
private, and add friends as appropriate.
==========

[Tom Sepez, 2016-12-07 21:06:26]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2016-12-07 21:12:56]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-12-07 21:12:57]

lgtm

https://codereview.chromium.org/2560783003/diff/1/core/fxcrt/fx_extension.cpp
File core/fxcrt/fx_extension.cpp (right):

https://codereview.chromium.org/2560783003/diff/1/core/fxcrt/fx_extension.cpp...
core/fxcrt/fx_extension.cpp:157: friend CFX_RetainPtr<T>
pdfium::MakeRetain(Args&&... args);
I didn't know you could do that..... cool.

[commit-bot: I haz the power, 2016-12-07 21:13:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-12-07 21:14:58]

https://codereview.chromium.org/2560783003/diff/20001/core/fxcrt/fx_extension...
File core/fxcrt/fx_extension.cpp (right):

https://codereview.chromium.org/2560783003/diff/20001/core/fxcrt/fx_extension...
core/fxcrt/fx_extension.cpp:77: template <typename T, typename... Args>
Note:  I moved these up top to give a strong hint to the reader that this is the
only way to make one of these objects.

[Tom Sepez, 2016-12-07 21:15:05]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-12-07 21:15:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2560783003/#ps20001
(title: "tidy")

[commit-bot: I haz the power, 2016-12-07 21:15:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 21:24:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 21:24:43]

Try jobs failed on following builders:
  linux_xfa_rel on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa_rel/b...)

[Tom Sepez, 2016-12-07 21:31:36]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-12-07 21:31:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2560783003/#ps40001
(title: "override required per chrome style")

[commit-bot: I haz the power, 2016-12-07 21:31:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 21:45:42]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481146296366220,
"parent_rev": "7cda31ac2f2884166f044937619478a6103198cf", "commit_rev":
"cd5e12a9ea397b48056643a7b65126395eec3174"}

[commit-bot: I haz the power, 2016-12-07 21:45:46]

Description was changed from

==========
Catch stray Retains() and Releases() outside of RetainPtr<>.

The previous CLs made the code clean, so now we can mark more things
private, and add friends as appropriate.
==========

to

==========
Catch stray Retains() and Releases() outside of RetainPtr<>.

The previous CLs made the code clean, so now we can mark more things
private, and add friends as appropriate.

Committed:
https://pdfium.googlesource.com/pdfium/+/cd5e12a9ea397b48056643a7b65126395eec...
==========

[commit-bot: I haz the power, 2016-12-07 21:45:46]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/cd5e12a9ea397b48056643a7b65126395eec...