Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Side by Side Diff: xfa/fxfa/parser/cxfa_widetextread.h

Issue 2560783003: Catch stray Retains() and Releases() outside of RetainPtr<>. (Closed)
Patch Set: override required per chrome style Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fgas/crt/fgas_stream.cpp ('k') | xfa/fxfa/parser/cxfa_widetextread.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef XFA_FXFA_PARSER_CXFA_WIDETEXTREAD_H_ 7 #ifndef XFA_FXFA_PARSER_CXFA_WIDETEXTREAD_H_
8 #define XFA_FXFA_PARSER_CXFA_WIDETEXTREAD_H_ 8 #define XFA_FXFA_PARSER_CXFA_WIDETEXTREAD_H_
9 9
10 #include "core/fxcrt/cfx_retain_ptr.h"
10 #include "xfa/fgas/crt/fgas_stream.h" 11 #include "xfa/fgas/crt/fgas_stream.h"
11 12
12 class CXFA_WideTextRead : public IFGAS_Stream { 13 class CXFA_WideTextRead : public IFGAS_Stream {
13 public: 14 public:
14 explicit CXFA_WideTextRead(const CFX_WideString& wsBuffer); 15 template <typename T, typename... Args>
16 friend CFX_RetainPtr<T> pdfium::MakeRetain(Args&&... args);
15 17
16 // IFGAS_Stream 18 // IFGAS_Stream
17 uint32_t GetAccessModes() const override; 19 uint32_t GetAccessModes() const override;
18 int32_t GetLength() const override; 20 int32_t GetLength() const override;
19 int32_t Seek(FX_STREAMSEEK eSeek, int32_t iOffset) override; 21 int32_t Seek(FX_STREAMSEEK eSeek, int32_t iOffset) override;
20 int32_t GetPosition() override; 22 int32_t GetPosition() override;
21 bool IsEOF() const override; 23 bool IsEOF() const override;
22 int32_t ReadData(uint8_t* pBuffer, int32_t iBufferSize) override; 24 int32_t ReadData(uint8_t* pBuffer, int32_t iBufferSize) override;
23 int32_t ReadString(FX_WCHAR* pStr, int32_t iMaxLength, bool& bEOS) override; 25 int32_t ReadString(FX_WCHAR* pStr, int32_t iMaxLength, bool& bEOS) override;
24 int32_t WriteData(const uint8_t* pBuffer, int32_t iBufferSize) override; 26 int32_t WriteData(const uint8_t* pBuffer, int32_t iBufferSize) override;
25 int32_t WriteString(const FX_WCHAR* pStr, int32_t iLength) override; 27 int32_t WriteString(const FX_WCHAR* pStr, int32_t iLength) override;
26 void Flush() override {} 28 void Flush() override {}
27 bool SetLength(int32_t iLength) override; 29 bool SetLength(int32_t iLength) override;
28 int32_t GetBOM(uint8_t bom[4]) const override; 30 int32_t GetBOM(uint8_t bom[4]) const override;
29 uint16_t GetCodePage() const override; 31 uint16_t GetCodePage() const override;
30 uint16_t SetCodePage(uint16_t wCodePage) override; 32 uint16_t SetCodePage(uint16_t wCodePage) override;
31 CFX_RetainPtr<IFGAS_Stream> CreateSharedStream(uint32_t dwAccess, 33 CFX_RetainPtr<IFGAS_Stream> CreateSharedStream(uint32_t dwAccess,
32 int32_t iOffset, 34 int32_t iOffset,
33 int32_t iLength) override; 35 int32_t iLength) override;
34 36
35 CFX_WideString GetSrcText() const; 37 CFX_WideString GetSrcText() const;
36 38
37 protected: 39 protected:
40 explicit CXFA_WideTextRead(const CFX_WideString& wsBuffer);
41 ~CXFA_WideTextRead() override;
42
38 CFX_WideString m_wsBuffer; 43 CFX_WideString m_wsBuffer;
39 int32_t m_iPosition; 44 int32_t m_iPosition;
40 }; 45 };
41 46
42 #endif // XFA_FXFA_PARSER_CXFA_WIDETEXTREAD_H_ 47 #endif // XFA_FXFA_PARSER_CXFA_WIDETEXTREAD_H_
OLDNEW
« no previous file with comments | « xfa/fgas/crt/fgas_stream.cpp ('k') | xfa/fxfa/parser/cxfa_widetextread.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698