Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: xfa/fxfa/parser/cxfa_widetextread.h

Issue 2560783003: Catch stray Retains() and Releases() outside of RetainPtr<>. (Closed)
Patch Set: override required per chrome style Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fgas/crt/fgas_stream.cpp ('k') | xfa/fxfa/parser/cxfa_widetextread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fxfa/parser/cxfa_widetextread.h
diff --git a/xfa/fxfa/parser/cxfa_widetextread.h b/xfa/fxfa/parser/cxfa_widetextread.h
index d3d3b3792a10106e3b5f8a6a802d9d462810aa38..2ccb042908c293ce0fb54827ffaf2ae24e07b790 100644
--- a/xfa/fxfa/parser/cxfa_widetextread.h
+++ b/xfa/fxfa/parser/cxfa_widetextread.h
@@ -7,11 +7,13 @@
#ifndef XFA_FXFA_PARSER_CXFA_WIDETEXTREAD_H_
#define XFA_FXFA_PARSER_CXFA_WIDETEXTREAD_H_
+#include "core/fxcrt/cfx_retain_ptr.h"
#include "xfa/fgas/crt/fgas_stream.h"
class CXFA_WideTextRead : public IFGAS_Stream {
public:
- explicit CXFA_WideTextRead(const CFX_WideString& wsBuffer);
+ template <typename T, typename... Args>
+ friend CFX_RetainPtr<T> pdfium::MakeRetain(Args&&... args);
// IFGAS_Stream
uint32_t GetAccessModes() const override;
@@ -35,6 +37,9 @@ class CXFA_WideTextRead : public IFGAS_Stream {
CFX_WideString GetSrcText() const;
protected:
+ explicit CXFA_WideTextRead(const CFX_WideString& wsBuffer);
+ ~CXFA_WideTextRead() override;
+
CFX_WideString m_wsBuffer;
int32_t m_iPosition;
};
« no previous file with comments | « xfa/fgas/crt/fgas_stream.cpp ('k') | xfa/fxfa/parser/cxfa_widetextread.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698