Run native_theme unittests everywhere we run views_unittests.

Run native_theme unittests everywhere we run views_unittests.

Created by adding the following to testing/buildbot/manage.py in
def process_file(..):

   if 'views_unittests' in seen and 'native_theme_unittests' not in seen:
     data = [d for d in gtest_tests if d['test'] == 'views_unittests'][0].copy()
     data['test'] = 'native_theme_unittests'
     gtest_tests.append(data)

Then running manage.py --write. It told me to put an entry in
gn_isolate_map.pyl as well.

BUG=398316
Committed: https://crrev.com/5f112f29f443bd65c36300272e0f1b89955a0d25
Cr-Commit-Position: refs/heads/master@{#437807}

[tapted, 2016-12-08 02:01:22]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 02:02:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 02:29:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 02:29:25]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tapted, 2016-12-08 05:51:22]

Description was changed from

==========
Fold native_theme unittests into views_unittests.

There are only 2-7 tests in native_theme_unittests. They currently have
no bot coverage on any platform. They should.

Take a lightweight approach (although slightly "impure") and run the
native_theme unittests as part of views_unittests.

BUG=398316
==========

to

==========
Fold native_theme unittests into views_unittests.

There are only 2-7 tests in native_theme_unittests. They currently have
no bot coverage on any platform. They should. But there are 60 places
we'd need to put `native_theme_unittests` into builder recipes, and a
separate build step for so few tests feels excessive.

Take a lightweight approach (although slightly "impure") and run the
native_theme unittests as part of views_unittests.

It shouldn't go in ui_base_unittests because ui/base doesn't have a
dependency on ui/native_theme, but ui::NativeTheme is used a lot in
ui/views.

BUG=398316
==========

[tapted, 2016-12-08 05:51:22]

tapted@chromium.org changed reviewers:
+ sky@chromium.org

[tapted, 2016-12-08 05:51:48]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 05:52:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 06:51:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 06:51:04]

Dry run: This issue passed the CQ dry run.

[tapted, 2016-12-08 08:11:50]

Hi sky, wdyt? This feels a bit dirty, but I'll claim precedent from, e.g.,
things that ui/views is already doing to run things inside interactive_ui_tests
;)  (there's also views' webview_unittest.cc, run from chrome/test)

(some other things I explored and rationale is in the CL description).

[sky, 2016-12-08 16:09:23]

On 2016/12/08 08:11:50, tapted wrote:
> Hi sky, wdyt? This feels a bit dirty, but I'll claim precedent from, e.g.,
> things that ui/views is already doing to run things inside
interactive_ui_tests
> ;)  (there's also views' webview_unittest.cc, run from chrome/test)
> 
> (some other things I explored and rationale is in the CL description).

If I extend your argument should we put all new test code in existing tests so
we don't need to update bots?

It shouldn't be that hard to add a new unit test to testing/buildbots.

[tapted, 2016-12-09 01:18:01]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 01:19:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2016-12-09 02:18:16]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 02:19:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2016-12-09 02:31:22]

Description was changed from

==========
Fold native_theme unittests into views_unittests.

There are only 2-7 tests in native_theme_unittests. They currently have
no bot coverage on any platform. They should. But there are 60 places
we'd need to put `native_theme_unittests` into builder recipes, and a
separate build step for so few tests feels excessive.

Take a lightweight approach (although slightly "impure") and run the
native_theme unittests as part of views_unittests.

It shouldn't go in ui_base_unittests because ui/base doesn't have a
dependency on ui/native_theme, but ui::NativeTheme is used a lot in
ui/views.

BUG=398316
==========

to

==========
Run native_theme unittests everywhere we run views_unittests.

Created by adding the following to testing/buildbot/manage.py in
def process_file(..):

   if 'views_unittests' in seen and 'native_theme_unittests' not in seen:
     data = [d for d in gtest_tests if d['test'] == 'views_unittests'][0].copy()
     data['test'] = 'native_theme_unittests'
     gtest_tests.append(data)

Then running manage.py --check. It told me to put an entry in
gn_isolate_map.pyl as well.

BUG=398316
==========

[tapted, 2016-12-09 02:38:53]

Description was changed from

==========
Run native_theme unittests everywhere we run views_unittests.

Created by adding the following to testing/buildbot/manage.py in
def process_file(..):

   if 'views_unittests' in seen and 'native_theme_unittests' not in seen:
     data = [d for d in gtest_tests if d['test'] == 'views_unittests'][0].copy()
     data['test'] = 'native_theme_unittests'
     gtest_tests.append(data)

Then running manage.py --check. It told me to put an entry in
gn_isolate_map.pyl as well.

BUG=398316
==========

to

==========
Run native_theme unittests everywhere we run views_unittests.

Created by adding the following to testing/buildbot/manage.py in
def process_file(..):

   if 'views_unittests' in seen and 'native_theme_unittests' not in seen:
     data = [d for d in gtest_tests if d['test'] == 'views_unittests'][0].copy()
     data['test'] = 'native_theme_unittests'
     gtest_tests.append(data)

Then running manage.py --write. It told me to put an entry in
gn_isolate_map.pyl as well.

BUG=398316
==========

[commit-bot: I haz the power, 2016-12-09 03:35:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 03:35:14]

Dry run: This issue passed the CQ dry run.

[tapted, 2016-12-09 03:51:18]

On 2016/12/08 16:09:23, sky wrote:
> On 2016/12/08 08:11:50, tapted wrote:
> > Hi sky, wdyt? This feels a bit dirty, but I'll claim precedent from, e.g.,
> > things that ui/views is already doing to run things inside
> interactive_ui_tests
> > ;)  (there's also views' webview_unittest.cc, run from chrome/test)
> > 
> > (some other things I explored and rationale is in the CL description).
> 
> If I extend your argument should we put all new test code in existing tests so
> we don't need to update bots?
> 
> It shouldn't be that hard to add a new unit test to testing/buildbots.

PTAL - I took the lazy (?) way out and modified `manage.py` to do it for me :)
(see Patchset 3)

[sky, 2016-12-09 16:03:19]

LGTM

https://codereview.chromium.org/2560633004/diff/40001/testing/buildbot/manage.py
File testing/buildbot/manage.py (right):

https://codereview.chromium.org/2560633004/diff/40001/testing/buildbot/manage...
testing/buildbot/manage.py:319: if 'views_unittests' in seen and
'native_theme_unittests' not in seen:
AWESOME!

[tapted, 2016-12-11 22:51:07]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-12-11 22:51:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-11 23:59:45]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481496667387320,
"parent_rev": "d521d270182f42d2e157bf7fac2b5d75f52899d2", "commit_rev":
"aa32427d1cdf40fe8f396d9794fac4bef6cd4acb"}

[commit-bot: I haz the power, 2016-12-12 00:00:10]

Description was changed from

==========
Run native_theme unittests everywhere we run views_unittests.

Created by adding the following to testing/buildbot/manage.py in
def process_file(..):

   if 'views_unittests' in seen and 'native_theme_unittests' not in seen:
     data = [d for d in gtest_tests if d['test'] == 'views_unittests'][0].copy()
     data['test'] = 'native_theme_unittests'
     gtest_tests.append(data)

Then running manage.py --write. It told me to put an entry in
gn_isolate_map.pyl as well.

BUG=398316
==========

to

==========
Run native_theme unittests everywhere we run views_unittests.

Created by adding the following to testing/buildbot/manage.py in
def process_file(..):

   if 'views_unittests' in seen and 'native_theme_unittests' not in seen:
     data = [d for d in gtest_tests if d['test'] == 'views_unittests'][0].copy()
     data['test'] = 'native_theme_unittests'
     gtest_tests.append(data)

Then running manage.py --write. It told me to put an entry in
gn_isolate_map.pyl as well.

BUG=398316

Review-Url: https://codereview.chromium.org/2560633004
==========

[commit-bot: I haz the power, 2016-12-12 00:00:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-12 15:10:10]

Description was changed from

==========
Run native_theme unittests everywhere we run views_unittests.

Created by adding the following to testing/buildbot/manage.py in
def process_file(..):

   if 'views_unittests' in seen and 'native_theme_unittests' not in seen:
     data = [d for d in gtest_tests if d['test'] == 'views_unittests'][0].copy()
     data['test'] = 'native_theme_unittests'
     gtest_tests.append(data)

Then running manage.py --write. It told me to put an entry in
gn_isolate_map.pyl as well.

BUG=398316

Review-Url: https://codereview.chromium.org/2560633004
==========

to

==========
Run native_theme unittests everywhere we run views_unittests.

Created by adding the following to testing/buildbot/manage.py in
def process_file(..):

   if 'views_unittests' in seen and 'native_theme_unittests' not in seen:
     data = [d for d in gtest_tests if d['test'] == 'views_unittests'][0].copy()
     data['test'] = 'native_theme_unittests'
     gtest_tests.append(data)

Then running manage.py --write. It told me to put an entry in
gn_isolate_map.pyl as well.

BUG=398316

Committed: https://crrev.com/5f112f29f443bd65c36300272e0f1b89955a0d25
Cr-Commit-Position: refs/heads/master@{#437807}
==========

[commit-bot: I haz the power, 2016-12-12 15:10:11]

Patchset 4 (id:??) landed as
https://crrev.com/5f112f29f443bd65c36300272e0f1b89955a0d25
Cr-Commit-Position: refs/heads/master@{#437807}