Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Side by Side Diff: testing/buildbot/manage.py

Issue 2560633004: Run native_theme unittests everywhere we run views_unittests. (Closed)
Patch Set: hack manage.py Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « testing/buildbot/gn_isolate_map.pyl ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2015 The Chromium Authors. All rights reserved. 2 # Copyright 2015 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Toolbox to manage all the json files in this directory. 6 """Toolbox to manage all the json files in this directory.
7 7
8 It can reformat them in their canonical format or ensures they are well 8 It can reformat them in their canonical format or ensures they are well
9 formatted. 9 formatted.
10 """ 10 """
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 ninja_targets_seen.add(test) 309 ninja_targets_seen.add(test)
310 310
311 name = d.get('name', d['test']) 311 name = d.get('name', d['test'])
312 if name in seen: 312 if name in seen:
313 raise Error('%s: %s / %s is listed multiple times.' % 313 raise Error('%s: %s / %s is listed multiple times.' %
314 (filename, builder, name)) 314 (filename, builder, name))
315 seen.add(name) 315 seen.add(name)
316 d.setdefault('swarming', {}).setdefault( 316 d.setdefault('swarming', {}).setdefault(
317 'can_use_on_swarming_builders', False) 317 'can_use_on_swarming_builders', False)
318 318
319 if 'views_unittests' in seen and 'native_theme_unittests' not in seen:
sky 2016/12/09 16:03:19 AWESOME!
320 data = [d for d in gtest_tests if d['test'] == 'views_unittests'][0].copy(
321 )
322 data['test'] = 'native_theme_unittests'
323 gtest_tests.append(data)
324
319 if gtest_tests: 325 if gtest_tests:
320 config[builder]['gtest_tests'] = sorted( 326 config[builder]['gtest_tests'] = sorted(
321 gtest_tests, key=lambda x: x['test']) 327 gtest_tests, key=lambda x: x['test'])
322 328
323 for d in data.get('isolated_scripts', []): 329 for d in data.get('isolated_scripts', []):
324 name = d['isolate_name'] 330 name = d['isolate_name']
325 if (name not in ninja_targets and 331 if (name not in ninja_targets and
326 name not in SKIP_GN_ISOLATE_MAP_TARGETS): 332 name not in SKIP_GN_ISOLATE_MAP_TARGETS):
327 raise Error('%s: %s / %s is not listed in gn_isolate_map.pyl.' % 333 raise Error('%s: %s / %s is not listed in gn_isolate_map.pyl.' %
328 (filename, builder, name)) 334 (filename, builder, name))
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
478 elif args.mode == 'remaining': 484 elif args.mode == 'remaining':
479 print_remaining(args.test_name, tests_location) 485 print_remaining(args.test_name, tests_location)
480 return result 486 return result
481 except Error as e: 487 except Error as e:
482 sys.stderr.write('%s\n' % e) 488 sys.stderr.write('%s\n' % e)
483 return 1 489 return 1
484 490
485 491
486 if __name__ == "__main__": 492 if __name__ == "__main__":
487 sys.exit(main()) 493 sys.exit(main())
OLDNEW
« no previous file with comments | « testing/buildbot/gn_isolate_map.pyl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698