Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 2560553002: Add DialogShowParams to <dialog>'s show() and showModal() (Closed)

Created:
4 years ago by Dan Beam
Modified:
3 years, 9 months ago
Reviewers:
tkent
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, blink-reviews-bindings_chromium.org, falken, esprehn
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DialogShowParams to <dialog>'s show() and showModal() Currently, this has only 1 option: skipFocusing = true/false You invoke this via: dialogElement.showModal({skipFocusing: true}); and set your own focus. Omitting the DialogShowParams does nothing. Rationale: https://github.com/whatwg/html/issues/1929 Spec addition: https://github.com/whatwg/html/pull/2197 R=tkent@chromium.org BUG=656924

Patch Set 1 : remove anchor #

Patch Set 2 : merge & rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/core/html/DialogShowParams.idl View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDialogElement.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDialogElement.cpp View 1 3 chunks +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDialogElement.idl View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (13 generated)
Dan Beam
third time's a charm
4 years ago (2016-12-20 19:58:11 UTC) #5
tkent
Please follow a process: http://www.chromium.org/blink/launching-features This needs a chromestatus.com entry and intent-to-implement-and-ship.
4 years ago (2016-12-20 23:18:38 UTC) #9
Dan Beam
3 years, 11 months ago (2016-12-29 22:39:45 UTC) #12
On 2016/12/20 23:18:38, slow_or_unavailable wrote:
> Please follow a process: http://www.chromium.org/blink/launching-features
> This needs a http://chromestatus.com entry and intent-to-implement-and-ship.

https://www.chromestatus.com/features/5121613552943104
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Tanq8NVTar0

Powered by Google App Engine
This is Rietveld 408576698