third_party/WebKit/Source/core/html/HTMLDialogElement.h - Issue 2560553002: Add DialogShowParams to <dialog>'s show() and showModal()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLDialogElement.h

Issue 2560553002: Add DialogShowParams to <dialog>'s show() and showModal() (Closed)

Patch Set: merge & rename Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLDialogElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLDialogElement.h b/third_party/WebKit/Source/core/html/HTMLDialogElement.h

index 6b92e393ec2bce44761f9054986a996dcba7f2c1..e238cbbf0055934a67ffcdcde3825a71312564a8 100644

--- a/third_party/WebKit/Source/core/html/HTMLDialogElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLDialogElement.h

@@ -30,6 +30,7 @@

namespace blink {

+class DialogShowParams;

class Document;

class ExceptionState;

class QualifiedName;

@@ -42,8 +43,8 @@ class HTMLDialogElement final : public HTMLElement {

void close(const String& returnValue, ExceptionState&);

void closeDialog(const String& returnValue = String());

- void show();

- void showModal(ExceptionState&);

+ void show(const DialogShowParams&);

+ void showModal(const DialogShowParams&, ExceptionState&);

void removedFrom(ContainerNode*) override;

// NotCentered means do not center the dialog. Centered means the dialog has