Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: third_party/WebKit/Source/core/html/HTMLDialogElement.idl

Issue 2560553002: Add DialogShowParams to <dialog>'s show() and showModal() (Closed)
Patch Set: merge & rename Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLDialogElement.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLDialogElement.idl
diff --git a/third_party/WebKit/Source/core/html/HTMLDialogElement.idl b/third_party/WebKit/Source/core/html/HTMLDialogElement.idl
index e6704616f29c3164b46f5a32d31e02d4969993a7..a7c733179e75dd0775649add18a02b448924e87b 100644
--- a/third_party/WebKit/Source/core/html/HTMLDialogElement.idl
+++ b/third_party/WebKit/Source/core/html/HTMLDialogElement.idl
@@ -28,9 +28,8 @@
interface HTMLDialogElement : HTMLElement {
[CEReactions, Reflect] attribute boolean open;
attribute DOMString returnValue;
- // FIXME: show() and showModal() should take an anchor argument.
- [CEReactions] void show();
- [CEReactions, RaisesException] void showModal();
+ [CEReactions] void show(optional DialogShowParams params);
+ [CEReactions, RaisesException] void showModal(optional DialogShowParams params);
// FIXME: The returnValue argument should have no default value.
[CEReactions, RaisesException] void close(optional DOMString returnValue = null);
};
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLDialogElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698