Make NodeIterator.detach() a no-op

Make NodeIterator.detach() a no-op

Make NodeIterator.detach() a no-op as per the DOM specification:
http://dom.spec.whatwg.org/#dom-nodeiterator-detach

This makes the code simpler, and a bit more efficient.

Firefox already does this since version 22:
https://bugzilla.mozilla.org/show_bug.cgi?id=823549

However, this method is not a no-op in IE11.

R=arv@chromium.org, tkent@chromium.org
BUG=367558
TEST=fast/dom/NodeIterator/detach-no-op.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172768

[tkent, 2014-04-28 01:37:12]

Same comment as Range.detach.

[tkent, 2014-04-28 12:13:51]

On 2014/04/28 01:37:12, tkent wrote:
> Same comment as Range.detach.

IE has supported NodeIterator since v9.  This behavior change would be very low
risk.
http://msdn.microsoft.com/en-us/library/ie/ff974357(v=vs.85).aspx

[tkent, 2014-04-28 12:15:38]

lgtm

https://codereview.chromium.org/256013002/diff/1/Source/core/frame/UseCounter...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/256013002/diff/1/Source/core/frame/UseCounter...
Source/core/frame/UseCounter.cpp:716: return "'NodeIterator.detach' is now a
no-op, as per DOM4 (http://dom.spec.whatwg.org/#dom-nodeiterator-detach).";
It's not DOM*4*.

[arv (Not doing code reviews), 2014-04-28 14:22:24]

LGTM

https://codereview.chromium.org/256013002/diff/1/Source/core/dom/NodeIterator...
File Source/core/dom/NodeIterator.cpp (right):

https://codereview.chromium.org/256013002/diff/1/Source/core/dom/NodeIterator...
Source/core/dom/NodeIterator.cpp:138: // This is now a no-op as per the DOM
specification.
Why not use the IDL extended attribute?

https://codereview.chromium.org/256013002/diff/1/Source/core/frame/UseCounter...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/256013002/diff/1/Source/core/frame/UseCounter...
Source/core/frame/UseCounter.cpp:716: return "'NodeIterator.detach' is now a
no-op, as per DOM4 (http://dom.spec.whatwg.org/#dom-nodeiterator-detach).";
s/DOM4/DOM/

[Inactive, 2014-04-28 14:26:20]

https://codereview.chromium.org/256013002/diff/1/Source/core/dom/NodeIterator...
File Source/core/dom/NodeIterator.cpp (right):

https://codereview.chromium.org/256013002/diff/1/Source/core/dom/NodeIterator...
Source/core/dom/NodeIterator.cpp:138: // This is now a no-op as per the DOM
specification.
On 2014/04/28 14:22:24, arv wrote:
> Why not use the IDL extended attribute?

Done.

https://codereview.chromium.org/256013002/diff/1/Source/core/frame/UseCounter...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/256013002/diff/1/Source/core/frame/UseCounter...
Source/core/frame/UseCounter.cpp:716: return "'NodeIterator.detach' is now a
no-op, as per DOM4 (http://dom.spec.whatwg.org/#dom-nodeiterator-detach).";
On 2014/04/28 14:22:24, arv wrote:
> s/DOM4/DOM/

Done.

https://codereview.chromium.org/256013002/diff/1/Source/core/frame/UseCounter...
Source/core/frame/UseCounter.cpp:716: return "'NodeIterator.detach' is now a
no-op, as per DOM4 (http://dom.spec.whatwg.org/#dom-nodeiterator-detach).";
On 2014/04/28 12:15:38, tkent wrote:
> It's not DOM*4*.

Done.

[Inactive, 2014-04-28 14:26:30]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-04-28 14:26:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/256013002/20001

[commit-bot: I haz the power, 2014-04-28 15:38:31]

Change committed as 172768