Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 256013002: Make NodeIterator.detach() a no-op (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 1
2 /* 2 /*
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 694 matching lines...) Expand 10 before | Expand all | Expand 10 after
705 705
706 case DocumentCreateAttributeNS: 706 case DocumentCreateAttributeNS:
707 return "'Document.createAttributeNS' is deprecated and has been removed from DOM4 (http://w3.org/tr/dom)."; 707 return "'Document.createAttributeNS' is deprecated and has been removed from DOM4 (http://w3.org/tr/dom).";
708 708
709 case AttributeOwnerElement: 709 case AttributeOwnerElement:
710 return "'Attr.ownerElement' is deprecated and has been removed from DOM4 (http://w3.org/tr/dom)."; 710 return "'Attr.ownerElement' is deprecated and has been removed from DOM4 (http://w3.org/tr/dom).";
711 711
712 case ElementSetAttributeNodeNS: 712 case ElementSetAttributeNodeNS:
713 return "'Element.setAttributeNodeNS' is deprecated and has been removed from DOM4 (http://w3.org/tr/dom)."; 713 return "'Element.setAttributeNodeNS' is deprecated and has been removed from DOM4 (http://w3.org/tr/dom).";
714 714
715 case NodeIteratorDetach:
716 return "'NodeIterator.detach' is now a no-op, as per DOM4 (http://dom.sp ec.whatwg.org/#dom-nodeiterator-detach).";
tkent 2014/04/28 12:15:38 It's not DOM*4*.
arv (Not doing code reviews) 2014/04/28 14:22:24 s/DOM4/DOM/
Inactive 2014/04/28 14:26:20 Done.
Inactive 2014/04/28 14:26:20 Done.
717
715 // Features that aren't deprecated don't have a deprecation message. 718 // Features that aren't deprecated don't have a deprecation message.
716 default: 719 default:
717 return String(); 720 return String();
718 } 721 }
719 } 722 }
720 723
721 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 724 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
722 { 725 {
723 ASSERT(feature >= firstCSSProperty); 726 ASSERT(feature >= firstCSSProperty);
724 ASSERT(feature <= lastCSSProperty); 727 ASSERT(feature <= lastCSSProperty);
(...skipping 28 matching lines...) Expand all
753 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 756 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
754 { 757 {
755 // FIXME: We may want to handle stylesheets that have multiple owners 758 // FIXME: We may want to handle stylesheets that have multiple owners
756 // http://crbug.com/242125 759 // http://crbug.com/242125
757 if (sheetContents && sheetContents->hasSingleOwnerNode()) 760 if (sheetContents && sheetContents->hasSingleOwnerNode())
758 return getFrom(sheetContents->singleOwnerDocument()); 761 return getFrom(sheetContents->singleOwnerDocument());
759 return 0; 762 return 0;
760 } 763 }
761 764
762 } // namespace WebCore 765 } // namespace WebCore
OLDNEW
« Source/core/dom/NodeIterator.cpp ('K') | « Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698