Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(38)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/fast/dom/NodeIterator/detach-no-op-expected.txt
Issue
256013002
:
Make NodeIterator.detach() a no-op (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Take feedback into consideration
Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/fast/dom/NodeIterator/detach-no-op.html
LayoutTests/fast/dom/NodeIterator/detach-no-op-expected.txt
LayoutTests/fast/dom/node-iterator-with-doctype-root-expected.txt
Source/core/dom/NodeIterator.h
Source/core/dom/NodeIterator.cpp
Source/core/dom/NodeIterator.idl
Source/core/frame/UseCounter.h
Source/core/frame/UseCounter.cpp
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« LayoutTests/fast/dom/NodeIterator/detach-no-op.html
('k') |
LayoutTests/fast/dom/node-iterator-with-doctype-root-expected.txt »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
CONSOLE WARNING: 'NodeIterator.detach' is now a no-op, as per DOM (http://dom.sp ec.whatwg.org/#dom-nodeiterator-detach).
2
This test checks that NodeIterator.detach() is a no-op.
3
4
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".
5
6
7
PASS iterator.nextNode().id is "a"
8
PASS iterator.detach() did not throw exception.
9
PASS iterator.nextNode().id is "b"
10
PASS successfullyParsed is true
11
12
TEST COMPLETE
13
OLD
NEW
« no previous file with comments
|
« LayoutTests/fast/dom/NodeIterator/detach-no-op.html
('k') |
LayoutTests/fast/dom/node-iterator-with-doctype-root-expected.txt »
('j') |
no next file with comments »
Issue 256013002: Make NodeIterator.detach() a no-op (Closed)
Created 6 years, 8 months ago by Inactive
Modified 6 years, 7 months ago
Reviewers: arv (Not doing code reviews), tkent
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 6
This is Rietveld
408576698
Chromium Code Reviews
Issue 256013002:
Make NodeIterator.detach() a no-op (Closed)
Base URL: svn://svn.chromium.org/blink/trunk