DevTools: Remove unused variables. Disallow unused variables with eslint

DevTools: Remove unused variables. Disallow unused variables with eslint

BUG=none

Committed: https://crrev.com/aaad280294a29e3c0632b015a2360279a93fadcd
Cr-Commit-Position: refs/heads/master@{#438768}

[einbinder, 2016-12-10 00:47:36]

einbinder@chromium.org changed reviewers:
+ dgozman@chromium.org

[einbinder, 2016-12-10 00:47:37]

ptal

https://codereview.chromium.org/2560043005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js (left):

https://codereview.chromium.org/2560043005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js:1811:
this.dispatchEventToListeners(SDK.DOMModel.Events.UndoRedoRequested);
Nothing even uses these events.

[dgozman, 2016-12-10 02:15:14]

lgtm

https://codereview.chromium.org/2560043005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js
(left):

https://codereview.chromium.org/2560043005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js:179: var
totalTime = this._calculator.boundarySpan();
Let's double-check for side-effects.

https://codereview.chromium.org/2560043005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js
(right):

https://codereview.chromium.org/2560043005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js:177:
this._restoringWindow = true;
Let's maybe remove more now?

https://codereview.chromium.org/2560043005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
(left):

https://codereview.chromium.org/2560043005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:1514:
var pieChart = Timeline.TimelineUIUtils.generatePieChart(frame.timeByCategory);
Doesn't this one have side effect?

[einbinder, 2016-12-12 20:41:19]

https://codereview.chromium.org/2560043005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js
(left):

https://codereview.chromium.org/2560043005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js:179: var
totalTime = this._calculator.boundarySpan();
On 2016/12/10 at 02:15:14, dgozman wrote:
> Let's double-check for side-effects.

Done.

https://codereview.chromium.org/2560043005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js
(right):

https://codereview.chromium.org/2560043005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js:177:
this._restoringWindow = true;
On 2016/12/10 at 02:15:14, dgozman wrote:
> Let's maybe remove more now?

Done.

https://codereview.chromium.org/2560043005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
(left):

https://codereview.chromium.org/2560043005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:1514:
var pieChart = Timeline.TimelineUIUtils.generatePieChart(frame.timeByCategory);
On 2016/12/10 at 02:15:14, dgozman wrote:
> Doesn't this one have side effect?

Nope

[einbinder, 2016-12-12 20:41:23]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2016-12-12 20:41:23]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2560043005/#ps20001
(title: "More unused")

[commit-bot: I haz the power, 2016-12-12 20:42:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[einbinder, 2016-12-12 20:46:20]

The CQ bit was unchecked by einbinder@chromium.org

[einbinder, 2016-12-12 20:49:46]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2016-12-12 20:49:46]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2560043005/#ps40001
(title: "unused events")

[commit-bot: I haz the power, 2016-12-12 20:51:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 23:50:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 23:50:55]

Failed to apply patch for
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:424
  error: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:
patch does not apply

Patch:      
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
diff --git
a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
index
61fe3f9314e7d7b23258fe557b9697d30898c70a..4072d5ae9fcc87d14d06d86be8d9d7be3daef6fc
100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
@@ -424,10 +424,8 @@ Timeline.TimelinePanel = class extends UI.Panel {
       hasSelection = true;
     }
     var predefinedRates = new Map([
-      [1, Common.UIString('No CPU throttling')],
-      [2, Common.UIString('2\xD7 slowdown')],
-      [5, Common.UIString('5\xD7 slowdown')],
-      [10, Common.UIString('10\xD7 slowdown')],
+      [1, Common.UIString('No CPU throttling')], [2, Common.UIString('2\xD7
slowdown')],
+      [5, Common.UIString('5\xD7 slowdown')], [10, Common.UIString('10\xD7
slowdown')],
       [20, Common.UIString('20\xD7 slowdown')]
     ]);
     for (var rate of predefinedRates)
@@ -1064,7 +1062,7 @@ Timeline.TimelinePanel = class extends UI.Panel {
    */
   _showSnapshotInPaintProfiler(snapshot) {
     var paintProfilerView = this._paintProfilerView();
-    var hasProfileData = paintProfilerView.setSnapshot(snapshot);
+    paintProfilerView.setSnapshot(snapshot);
     if
(!this._detailsView.hasTab(Timeline.TimelinePanel.DetailsTab.PaintProfiler)) {
       this._detailsView.appendTab(
           Timeline.TimelinePanel.DetailsTab.PaintProfiler,
Common.UIString('Paint Profiler'), paintProfilerView,

[einbinder, 2016-12-13 00:28:32]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2016-12-13 00:28:33]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2560043005/#ps60001
(title: "Merge")

[commit-bot: I haz the power, 2016-12-13 00:29:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 02:06:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 02:06:44]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[einbinder, 2016-12-13 19:43:40]

The CQ bit was checked by einbinder@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 19:44:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 19:55:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 19:55:21]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[einbinder, 2016-12-14 21:22:01]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2016-12-14 21:22:02]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2560043005/#ps80001
(title: "Merge")

[commit-bot: I haz the power, 2016-12-14 21:22:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 22:44:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 22:44:32]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[einbinder, 2016-12-15 03:33:51]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2016-12-15 03:33:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2560043005/#ps100001
(title: "A new unused variable was born")

[commit-bot: I haz the power, 2016-12-15 03:34:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 06:44:03]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481772831067770,
"parent_rev": "50d5b76d95bc026282172fde0b712c1cfe295829", "commit_rev":
"dfd1bceac08c0f0fa7e2f761b95b788b10d7386f"}

[commit-bot: I haz the power, 2016-12-15 06:44:51]

Description was changed from

==========
DevTools: Remove unused variables. Disallow unused variables with eslint

BUG=none
==========

to

==========
DevTools: Remove unused variables. Disallow unused variables with eslint

BUG=none

Review-Url: https://codereview.chromium.org/2560043005
==========

[commit-bot: I haz the power, 2016-12-15 06:44:52]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-15 06:46:15]

Description was changed from

==========
DevTools: Remove unused variables. Disallow unused variables with eslint

BUG=none

Review-Url: https://codereview.chromium.org/2560043005
==========

to

==========
DevTools: Remove unused variables. Disallow unused variables with eslint

BUG=none

Committed: https://crrev.com/aaad280294a29e3c0632b015a2360279a93fadcd
Cr-Commit-Position: refs/heads/master@{#438768}
==========

[commit-bot: I haz the power, 2016-12-15 06:46:17]

Patchset 6 (id:??) landed as
https://crrev.com/aaad280294a29e3c0632b015a2360279a93fadcd
Cr-Commit-Position: refs/heads/master@{#438768}