third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js - Issue 2560043005: DevTools: Remove unused variables. Disallow unused variables with eslint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2560043005: DevTools: Remove unused variables. Disallow unused variables with eslint (Closed)

Patch Set: A new unused variable was born Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

index 6fb1f1373176b0bd539267fe7691776380ec1de7..7e502bacdb1adef3396770bbb75364cb4e497df7 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

@@ -470,7 +470,7 @@ Network.NetworkLogViewColumns = class {

var index = this._columns.findIndex(columnConfig => columnConfig.id === headerId);

if (index === -1)

return false;

- var columnConfig = this._columns.splice(index, 1);

+ this._columns.splice(index, 1);

this._dataGrid.removeColumn(headerId);

this._saveColumns();

this._updateColumns();