Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2559933002: assembler-arm: Use unsigned ints to avoid integer overflow. (Closed)

Created:
4 years ago by Matt Giuca
Modified:
4 years ago
Reviewers:
bbudge
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

assembler-arm: Use unsigned ints to avoid integer overflow. BUG=v8:5725 Committed: https://crrev.com/2cc4b0e025f19681468e28911701b1eac8b0fdda Cr-Commit-Position: refs/heads/master@{#41570}

Patch Set 1 #

Patch Set 2 : Formatting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/arm/assembler-arm.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Matt Giuca
4 years ago (2016-12-08 03:53:40 UTC) #2
Matt Giuca
Formatting.
4 years ago (2016-12-08 04:17:49 UTC) #4
bbudge
lgtm
4 years ago (2016-12-08 06:16:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559933002/20001
4 years ago (2016-12-08 06:18:07 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 06:19:49 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-08 06:20:23 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2cc4b0e025f19681468e28911701b1eac8b0fdda
Cr-Commit-Position: refs/heads/master@{#41570}

Powered by Google App Engine
This is Rietveld 408576698