Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: src/arm/assembler-arm.cc

Issue 2559933002: assembler-arm: Use unsigned ints to avoid integer overflow. (Closed)
Patch Set: Formatting. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/assembler-arm.cc
diff --git a/src/arm/assembler-arm.cc b/src/arm/assembler-arm.cc
index 0a671c06244aefca6d2ca8997a8c35fd583281cd..6e0b2db281f045c72c95561f3d3d479cd46a79aa 100644
--- a/src/arm/assembler-arm.cc
+++ b/src/arm/assembler-arm.cc
@@ -3911,7 +3911,7 @@ void Assembler::vmov(const QwNeonRegister dst, const QwNeonRegister src) {
dst.split_code(&vd, &d);
int vm, m;
src.split_code(&vm, &m);
- emit(0x1E4 * B23 | d * B22 | 2 * B20 | vm * B16 | vd * B12 | B8 | m * B7 |
+ emit(0x1E4U * B23 | d * B22 | 2 * B20 | vm * B16 | vd * B12 | B8 | m * B7 |
B6 | m * B5 | B4 | vm);
}
@@ -3950,8 +3950,8 @@ void Assembler::veor(DwVfpRegister dst, DwVfpRegister src1,
src1.split_code(&vn, &n);
int vm, m;
src2.split_code(&vm, &m);
- emit(0x1E6 * B23 | d * B22 | vn * B16 | vd * B12 | B8 | n * B7 | m * B5 | B4 |
- vm);
+ emit(0x1E6U * B23 | d * B22 | vn * B16 | vd * B12 | B8 | n * B7 | m * B5 |
+ B4 | vm);
}
void Assembler::veor(QwNeonRegister dst, QwNeonRegister src1,
@@ -3964,8 +3964,8 @@ void Assembler::veor(QwNeonRegister dst, QwNeonRegister src1,
src1.split_code(&vn, &n);
int vm, m;
src2.split_code(&vm, &m);
- emit(0x1E6 * B23 | d * B22 | vn * B16 | vd * B12 | B8 | n * B7 | B6 | m * B5 |
- B4 | vm);
+ emit(0x1E6U * B23 | d * B22 | vn * B16 | vd * B12 | B8 | n * B7 | B6 |
+ m * B5 | B4 | vm);
}
// Pseudo instructions.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698