Source/web/ServiceWorkerGlobalScopeClientImpl.h - Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ServiceWorkerGlobalScopeClientImpl.h

Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/web/PrerendererClientImpl.h ('K') | « Source/web/PrerendererClientImpl.h ('k') | Source/web/ServiceWorkerGlobalScopeClientImpl.cpp » ('j') | Source/web/StorageQuotaClientImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/ServiceWorkerGlobalScopeClientImpl.h

diff --git a/Source/web/ServiceWorkerGlobalScopeClientImpl.h b/Source/web/ServiceWorkerGlobalScopeClientImpl.h

index 06c77edf8a7a002c63c3749eaadd676d3d71c81c..6cda5eabc8f06215f7320d803f66350a15f8038d 100644

--- a/Source/web/ServiceWorkerGlobalScopeClientImpl.h

+++ b/Source/web/ServiceWorkerGlobalScopeClientImpl.h

@@ -40,9 +40,10 @@ namespace blink {

class WebServiceWorkerContextClient;

class WebURL;

-class ServiceWorkerGlobalScopeClientImpl FINAL : public WebCore::ServiceWorkerGlobalScopeClient {

+class ServiceWorkerGlobalScopeClientImpl FINAL : public NoBaseWillBeGarbageCollectedFinalized<ServiceWorkerGlobalScopeClientImpl>, public WebCore::ServiceWorkerGlobalScopeClient {

haraken 2014/04/30 02:41:22 Ditto. You can make ServiceWorkerClient NoBaseWill

+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ServiceWorkerGlobalScopeClientImpl);

public:

- static PassOwnPtr<WebCore::ServiceWorkerGlobalScopeClient> create(PassOwnPtr<WebServiceWorkerContextClient>);

+ static PassOwnPtrWillBeRawPtr<WebCore::ServiceWorkerGlobalScopeClient> create(PassOwnPtr<WebServiceWorkerContextClient>);

virtual ~ServiceWorkerGlobalScopeClientImpl();

virtual void getClients(WebServiceWorkerClientsCallbacks*);

« Source/web/PrerendererClientImpl.h ('K') | « Source/web/PrerendererClientImpl.h ('k') | Source/web/ServiceWorkerGlobalScopeClientImpl.cpp » ('j') | Source/web/StorageQuotaClientImpl.h » ('J')