Source/web/ServiceWorkerGlobalScopeClientImpl.cpp - Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/web/ServiceWorkerGlobalScopeClientImpl.h ('K') | « Source/web/ServiceWorkerGlobalScopeClientImpl.h ('k') | Source/web/StorageQuotaClientImpl.h » ('j') | Source/web/StorageQuotaClientImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

diff --git a/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp b/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

index 2fa5b5ec056a33739f7eb39ecdbebe36971dcc87..9fe7a27f9cbb47ff3eb64fdd95b933374a27d477 100644

--- a/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

+++ b/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

@@ -40,9 +40,9 @@

namespace blink {

-PassOwnPtr<WebCore::ServiceWorkerGlobalScopeClient> ServiceWorkerGlobalScopeClientImpl::create(PassOwnPtr<WebServiceWorkerContextClient> client)

+PassOwnPtrWillBeRawPtr<WebCore::ServiceWorkerGlobalScopeClient> ServiceWorkerGlobalScopeClientImpl::create(PassOwnPtr<WebServiceWorkerContextClient> client)

{

- return adoptPtr(new ServiceWorkerGlobalScopeClientImpl(client));

+ return adoptPtrWillBeNoop(new ServiceWorkerGlobalScopeClientImpl(client));

}

ServiceWorkerGlobalScopeClientImpl::~ServiceWorkerGlobalScopeClientImpl()