Source/web/PrerendererClientImpl.h - Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PrerendererClientImpl.h

Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/web/DatabaseClientImpl.h ('K') | « Source/web/DatabaseClientImpl.cpp ('k') | Source/web/ServiceWorkerGlobalScopeClientImpl.h » ('j') | Source/web/ServiceWorkerGlobalScopeClientImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/PrerendererClientImpl.h

diff --git a/Source/web/PrerendererClientImpl.h b/Source/web/PrerendererClientImpl.h

index cd350d28267006681a789349a214e6fc4020595f..ec05d22a7aacbc7a16dc27ab832068cd2f024ee1 100644

--- a/Source/web/PrerendererClientImpl.h

+++ b/Source/web/PrerendererClientImpl.h

@@ -44,7 +44,8 @@ namespace blink {

class WebPrerendererClient;

-class PrerendererClientImpl FINAL : public WebCore::PrerendererClient {

+class PrerendererClientImpl FINAL : public NoBaseWillBeGarbageCollected<PrerendererClientImpl>, public WebCore::PrerendererClient {

haraken 2014/04/30 02:41:22 Ditto. You can make PrerendererClient NoBaseWillBe

+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(PrerendererClientImpl);

WTF_MAKE_NONCOPYABLE(PrerendererClientImpl);

public:

explicit PrerendererClientImpl(WebPrerendererClient*);