Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2559763003: Mac: Fix SSLClientCertificateSelectorCocoaTest.HideShow (fails on macOS Sierra). (Closed)

Created:
4 years ago by Patti Lor
Modified:
4 years ago
Reviewers:
tapted
CC:
chromium-reviews, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Fix SSLClientCertificateSelectorCocoaTest.HideShow (fails on macOS Sierra). SSLClientCertificateSelectorCocoaTest.HideShow is failing on macOS Sierra, blocking 10.12 rollout for Chrome. Fix this using the same refactor as seen in r400627, which ignores mouse events instead of resizing the certificate selector window when it's hidden. BUG=650898 Committed: https://crrev.com/88fc23eb6caa37caec392c54ceeab245e5adaac3 Cr-Commit-Position: refs/heads/master@{#438065}

Patch Set 1 #

Patch Set 2 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm View 1 1 chunk +3 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm View 1 chunk +6 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (13 generated)
Patti Lor
Hi Trent, PTAL. As for the broken-ness I mentioned in https://bugs.chromium.org/p/chromium/issues/detail?id=650898#c7, it also introduces that ...
4 years ago (2016-12-08 07:03:09 UTC) #10
tapted
lgtm
4 years ago (2016-12-09 04:06:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559763003/20001
4 years ago (2016-12-13 04:56:01 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 05:41:10 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-13 05:43:40 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/88fc23eb6caa37caec392c54ceeab245e5adaac3
Cr-Commit-Position: refs/heads/master@{#438065}

Powered by Google App Engine
This is Rietveld 408576698