Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

Issue 2559763003: Mac: Fix SSLClientCertificateSelectorCocoaTest.HideShow (fails on macOS Sierra). (Closed)
Patch Set: Cleanup. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm
index 09bb431a354c4fe0209c845f1e8105c3c277ed19..bd1890344066e8cdf56eadf18b30f15e85872a80 100644
--- a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm
+++ b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm
@@ -105,16 +105,17 @@ IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorCocoaTest, HideShow) {
content::RunAllPendingInMessageLoop();
NSWindow* sheetWindow = [[selector overlayWindow] attachedSheet];
- NSRect sheetFrame = [sheetWindow frame];
EXPECT_EQ(1.0, [sheetWindow alphaValue]);
- // Switch to another tab and verify that the sheet is hidden.
+ // Switch to another tab and verify that the sheet is hidden. Interaction with
+ // the tab underneath should not be blocked.
AddBlankTabAndShow(browser());
EXPECT_EQ(0.0, [sheetWindow alphaValue]);
- EXPECT_NSEQ(ui::kWindowSizeDeterminedLater, [sheetWindow frame]);
+ EXPECT_TRUE([[selector overlayWindow] ignoresMouseEvents]);
- // Switch back and verify that the sheet is shown.
+ // Switch back and verify that the sheet is shown. Interaction with the tab
+ // underneath should be blocked while the sheet is showing.
chrome::SelectNumberedTab(browser(), 0);
EXPECT_EQ(1.0, [sheetWindow alphaValue]);
- EXPECT_NSEQ(sheetFrame, [sheetWindow frame]);
+ EXPECT_FALSE([[selector overlayWindow] ignoresMouseEvents]);
}
« no previous file with comments | « chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698