Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2559763002: Refcount IFGAS_ streams all the time, too (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Refcount IFGAS_ streams all the time, too IFGAS_Streams are not part of the IFX_Stream hierarchy, but can be made from such. Committed: https://pdfium.googlesource.com/pdfium/+/7cda31ac2f2884166f044937619478a6103198cf

Patch Set 1 #

Patch Set 2 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -308 lines) Patch
M testing/libfuzzer/pdf_cfx_saxreader_fuzzer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M testing/libfuzzer/pdf_css_fuzzer.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M testing/libfuzzer/pdf_xml_fuzzer.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M xfa/fde/cfde_txtedtengine.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M xfa/fde/cfde_txtedtengine.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fde/css/fde_css.h View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/css/fde_cssstylesheet.h View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/css/fde_cssstylesheet.cpp View 1 3 chunks +7 lines, -5 lines 0 comments Download
M xfa/fde/css/fde_csssyntax.h View 1 4 chunks +4 lines, -3 lines 0 comments Download
M xfa/fde/css/fde_csssyntax.cpp View 1 2 chunks +12 lines, -9 lines 0 comments Download
M xfa/fde/xml/fde_xml_imp.h View 4 chunks +7 lines, -6 lines 0 comments Download
M xfa/fde/xml/fde_xml_imp.cpp View 4 chunks +6 lines, -4 lines 0 comments Download
M xfa/fde/xml/fde_xml_imp_unittest.cpp View 15 chunks +75 lines, -90 lines 0 comments Download
M xfa/fgas/crt/fgas_stream.h View 1 chunk +11 lines, -15 lines 0 comments Download
M xfa/fgas/crt/fgas_stream.cpp View 1 13 chunks +57 lines, -94 lines 0 comments Download
M xfa/fgas/font/cfgas_gefont.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M xfa/fgas/font/cfgas_gefont.cpp View 1 2 chunks +8 lines, -6 lines 0 comments Download
M xfa/fxfa/parser/cxfa_dataexporter.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_dataexporter.cpp View 5 chunks +10 lines, -12 lines 0 comments Download
M xfa/fxfa/parser/cxfa_node.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M xfa/fxfa/parser/cxfa_simple_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_simple_parser.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M xfa/fxfa/parser/cxfa_widetextread.h View 2 chunks +3 lines, -6 lines 0 comments Download
M xfa/fxfa/parser/cxfa_widetextread.cpp View 2 chunks +5 lines, -14 lines 0 comments Download
M xfa/fxfa/parser/cxfa_xml_parser.h View 2 chunks +3 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_xml_parser.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_utils.h View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Dan, ready for review.
4 years ago (2016-12-07 19:44:22 UTC) #6
dsinclair
lgtm
4 years ago (2016-12-07 20:09:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559763002/20001
4 years ago (2016-12-07 20:10:02 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-07 20:10:24 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/7cda31ac2f2884166f044937619478a61031...

Powered by Google App Engine
This is Rietveld 408576698