xfa/fxfa/parser/cxfa_xml_parser.cpp - Issue 2559763002: Refcount IFGAS_ streams all the time, too

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/cxfa_xml_parser.cpp

Issue 2559763002: Refcount IFGAS_ streams all the time, too (Closed)

Patch Set: more Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/cxfa_xml_parser.cpp

diff --git a/xfa/fxfa/parser/cxfa_xml_parser.cpp b/xfa/fxfa/parser/cxfa_xml_parser.cpp

index ac378f0b9541a58c7f256a33680b0b3d8fdf2427..6d2ef350d9e8a3693a79fede5af08ac40a76645f 100644

--- a/xfa/fxfa/parser/cxfa_xml_parser.cpp

+++ b/xfa/fxfa/parser/cxfa_xml_parser.cpp

@@ -6,7 +6,8 @@

#include "xfa/fxfa/parser/cxfa_xml_parser.h"

-CXFA_XMLParser::CXFA_XMLParser(CFDE_XMLNode* pRoot, IFGAS_Stream* pStream)

+CXFA_XMLParser::CXFA_XMLParser(CFDE_XMLNode* pRoot,

+ const CFX_RetainPtr<IFGAS_Stream>& pStream)

: m_nElementStart(0),

m_dwCheckStatus(0),

m_dwCurrentCheckStatus(0),

« no previous file with comments | « xfa/fxfa/parser/cxfa_xml_parser.h ('k') | xfa/fxfa/parser/xfa_utils.h » ('j') | no next file with comments »