xfa/fxfa/parser/cxfa_simple_parser.h - Issue 2559763002: Refcount IFGAS_ streams all the time, too

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/cxfa_simple_parser.h

Issue 2559763002: Refcount IFGAS_ streams all the time, too (Closed)

Patch Set: more Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/cxfa_simple_parser.h

diff --git a/xfa/fxfa/parser/cxfa_simple_parser.h b/xfa/fxfa/parser/cxfa_simple_parser.h

index 559df7124b9e2fe77962f21bcac218d208db7457..5f61ad7d28fbfd65d4e896453f9acfdd3b620e9c 100644

--- a/xfa/fxfa/parser/cxfa_simple_parser.h

+++ b/xfa/fxfa/parser/cxfa_simple_parser.h

@@ -78,7 +78,7 @@ class CXFA_SimpleParser {

CXFA_XMLParser* m_pXMLParser;

std::unique_ptr<CFDE_XMLDoc> m_pXMLDoc;

- std::unique_ptr<IFGAS_Stream, ReleaseDeleter<IFGAS_Stream>> m_pStream;

+ CFX_RetainPtr<IFGAS_Stream> m_pStream;

CFX_RetainPtr<IFX_SeekableReadStream> m_pFileRead;

CXFA_Document* m_pFactory;

CXFA_Node* m_pRootNode;

« no previous file with comments | « xfa/fxfa/parser/cxfa_node.cpp ('k') | xfa/fxfa/parser/cxfa_simple_parser.cpp » ('j') | no next file with comments »