[ObjC ARC] Converts ios/chrome/browser/passwords:unit_tests to ARC.

[ObjC ARC] Converts ios/chrome/browser/passwords:unit_tests to ARC.

Notable issues:
 * After replacing scoped_nsobjects with strong ivars, the tests started failing
because of the change in destruction order of TestWebState and its observer.
Patched TestWebState to reset its observers upon destruction, similar to
WebStateImpl.

BUG=624363
TEST=None

Committed: https://crrev.com/3de9dfcbfc1a9fd4cd7cc09feb2be207eb8301ce
Cr-Commit-Position: refs/heads/master@{#437223}

[stkhapugin, 2016-12-07 14:36:46]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 14:36:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 14:58:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 14:58:08]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[stkhapugin, 2016-12-07 17:07:08]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 17:07:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2016-12-07 17:25:15]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/passwords:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/passwords:unit_tests to ARC.

Notable issues:
 * After replacing scoped_nsobjects with strong ivars, the tests started failing
because of the change in destruction order of TestWebState and its observer.
Patched TestWebState to reset its observers upon destruction, similar to
WebStateImpl.

BUG=624363
TEST=None
==========

[stkhapugin, 2016-12-07 17:25:15]

stkhapugin@chromium.org changed reviewers:
+ eugenebut@chromium.org

[stkhapugin, 2016-12-07 17:25:22]

ptal

[Eugene But (OOO till 7-30), 2016-12-07 18:21:35]

lgtm

https://codereview.chromium.org/2559693003/diff/20001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/password_controller_unittest.mm (right):

https://codereview.chromium.org/2559693003/diff/20001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_controller_unittest.mm:217:
__unsafe_unretained void (^completionHandler)(BOOL);
Should this be __weal?

https://codereview.chromium.org/2559693003/diff/20001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/password_generation_agent_unittest.mm (right):

https://codereview.chromium.org/2559693003/diff/20001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_generation_agent_unittest.mm:487:
__unsafe_unretained void (^completion_handler)(BOOL);
ditto

[commit-bot: I haz the power, 2016-12-07 18:37:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 18:37:04]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2016-12-08 09:54:41]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2016-12-08 09:55:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 09:59:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481190881836870,
"parent_rev": "78f64c07a03600273c2b85ba7cbc66859bfcf0d3", "commit_rev":
"1baf68c50d441191d85aef4150353187da19843e"}

[commit-bot: I haz the power, 2016-12-08 09:59:57]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/passwords:unit_tests to ARC.

Notable issues:
 * After replacing scoped_nsobjects with strong ivars, the tests started failing
because of the change in destruction order of TestWebState and its observer.
Patched TestWebState to reset its observers upon destruction, similar to
WebStateImpl.

BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/passwords:unit_tests to ARC.

Notable issues:
 * After replacing scoped_nsobjects with strong ivars, the tests started failing
because of the change in destruction order of TestWebState and its observer.
Patched TestWebState to reset its observers upon destruction, similar to
WebStateImpl.

BUG=624363
TEST=None
==========

[commit-bot: I haz the power, 2016-12-08 09:59:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-08 10:01:26]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/passwords:unit_tests to ARC.

Notable issues:
 * After replacing scoped_nsobjects with strong ivars, the tests started failing
because of the change in destruction order of TestWebState and its observer.
Patched TestWebState to reset its observers upon destruction, similar to
WebStateImpl.

BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/passwords:unit_tests to ARC.

Notable issues:
 * After replacing scoped_nsobjects with strong ivars, the tests started failing
because of the change in destruction order of TestWebState and its observer.
Patched TestWebState to reset its observers upon destruction, similar to
WebStateImpl.

BUG=624363
TEST=None

Committed: https://crrev.com/3de9dfcbfc1a9fd4cd7cc09feb2be207eb8301ce
Cr-Commit-Position: refs/heads/master@{#437223}
==========

[commit-bot: I haz the power, 2016-12-08 10:01:27]

Patchset 2 (id:??) landed as
https://crrev.com/3de9dfcbfc1a9fd4cd7cc09feb2be207eb8301ce
Cr-Commit-Position: refs/heads/master@{#437223}

[stkhapugin, 2016-12-08 10:15:47]

Thanks!

https://codereview.chromium.org/2559693003/diff/20001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/password_controller_unittest.mm (right):

https://codereview.chromium.org/2559693003/diff/20001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_controller_unittest.mm:217:
__unsafe_unretained void (^completionHandler)(BOOL);
On 2016/12/07 18:21:35, Eugene But wrote:
> Should this be __weal?

Actually, no - grabbing arguments from NSInvocation is unsafe and memory
semantics do not apply, so ARC enforces __unsafe_unretained. It is assumed that
the argument is properly memory managed when the invocation is valid, which is
the case here as the invocation argument is retrieved during the invocation
dispatch.

https://codereview.chromium.org/2559693003/diff/20001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/password_generation_agent_unittest.mm (right):

https://codereview.chromium.org/2559693003/diff/20001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_generation_agent_unittest.mm:487:
__unsafe_unretained void (^completion_handler)(BOOL);
On 2016/12/07 18:21:35, Eugene But wrote:
> ditto

See above.

[stkhapugin, 2016-12-08 10:15:47]

https://codereview.chromium.org/2559693003/diff/20001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/password_controller_unittest.mm (right):

https://codereview.chromium.org/2559693003/diff/20001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_controller_unittest.mm:217:
__unsafe_unretained void (^completionHandler)(BOOL);
On 2016/12/07 18:21:35, Eugene But wrote:
> Should this be __weal?

Actually, no - grabbing arguments from NSInvocation is unsafe and memory
semantics do not apply, so ARC enforces __unsafe_unretained. It is assumed that
the argument is properly memory managed when the invocation is valid, which is
the case here as the invocation argument is retrieved during the invocation
dispatch.

https://codereview.chromium.org/2559693003/diff/20001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/password_generation_agent_unittest.mm (right):

https://codereview.chromium.org/2559693003/diff/20001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_generation_agent_unittest.mm:487:
__unsafe_unretained void (^completion_handler)(BOOL);
On 2016/12/07 18:21:35, Eugene But wrote:
> ditto

See above.