Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: ios/chrome/browser/passwords/credential_manager_js_unittest.mm

Issue 2559693003: [ObjC ARC] Converts ios/chrome/browser/passwords:unit_tests to ARC. (Closed)
Patch Set: Cleanup Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/passwords/credential_manager_js_unittest.mm
diff --git a/ios/chrome/browser/passwords/credential_manager_js_unittest.mm b/ios/chrome/browser/passwords/credential_manager_js_unittest.mm
index 37f0d660744ffb6356f4ee411c5bb86c707e6d58..f9f8fbfd5d7f18883c9e7e95430fd26e70250338 100644
--- a/ios/chrome/browser/passwords/credential_manager_js_unittest.mm
+++ b/ios/chrome/browser/passwords/credential_manager_js_unittest.mm
@@ -5,7 +5,6 @@
#include <memory>
#include "base/mac/foundation_util.h"
-#import "base/mac/scoped_nsobject.h"
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#import "ios/chrome/browser/passwords/js_credential_manager.h"
@@ -19,6 +18,10 @@
#include "testing/gtest_mac.h"
#include "url/gurl.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
namespace {
using ::testing::_;
@@ -59,9 +62,9 @@ class CredentialManagerJsTest : public web::WebTestWithWebState {
void SetUp() override {
web::WebTestWithWebState::SetUp();
- js_credential_manager_.reset(base::mac::ObjCCastStrict<JSCredentialManager>(
- [[web_state()->GetJSInjectionReceiver()
- instanceOfClass:[JSCredentialManager class]] retain]));
+ js_credential_manager_ = base::mac::ObjCCastStrict<JSCredentialManager>(
+ [web_state()->GetJSInjectionReceiver()
+ instanceOfClass:[JSCredentialManager class]]);
observer_.reset(new MockWebStateObserver(web_state()));
}
@@ -255,7 +258,7 @@ class CredentialManagerJsTest : public web::WebTestWithWebState {
private:
// Manager for injected credential manager JavaScript.
- base::scoped_nsobject<JSCredentialManager> js_credential_manager_;
+ JSCredentialManager* js_credential_manager_;
// Mock observer for testing.
std::unique_ptr<MockWebStateObserver> observer_;

Powered by Google App Engine
This is Rietveld 408576698