[ObjC ARC] Converts ios/chrome/browser/passwords:unit_tests to ARC.

ios/chrome/browser/passwords/password_generation_agent_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/passwords/password_generation_agent.h"
 
 #include <algorithm>
 #include <memory>
 
 #include "base/logging.h"
 #include "base/mac/foundation_util.h"
-#import "base/mac/scoped_nsobject.h"
 #include "base/mac/scoped_objc_class_swizzler.h"
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/string16.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "components/autofill/core/common/password_form.h"
 #import "components/autofill/ios/browser/js_suggestion_manager.h"
 #include "google_apis/gaia/gaia_urls.h"
 #import "ios/chrome/browser/autofill/form_input_accessory_view_controller.h"
 #import "ios/chrome/browser/passwords/js_password_manager.h"
 #import "ios/chrome/browser/passwords/password_generation_offer_view.h"
 #import "ios/chrome/browser/passwords/passwords_ui_delegate.h"
 #import "ios/chrome/browser/ui/commands/generic_chrome_command.h"
 #include "ios/chrome/browser/ui/commands/ios_command_ids.h"
 #import "ios/testing/ocmock_complex_type_helper.h"
 #include "ios/web/public/test/test_web_state.h"
 #include "ios/web/public/web_state/url_verification_constants.h"
 #import "ios/web/public/test/web_test_with_web_state.h"
 #include "testing/gtest_mac.h"
 #include "third_party/ocmock/OCMock/OCMock.h"
 #include "third_party/ocmock/gtest_support.h"
 #include "url/gurl.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 namespace {
 
 NSString* const kAccountCreationFormName = @"create-foo-account";
 NSString* const kAccountCreationFieldName = @"password";
 NSString* const kAccountCreationOrigin = @"http://foo.com/login";
 NSString* const kEmailFieldName = @"email";
 
 // Static storage to access arguments passed to swizzled method of UIWindow.
 static id g_chrome_execute_command_sender = nil;
 
@@ skipping 39 matching lines @@
 // swapped with UIWindow.
 @interface DonorWindow : NSObject
 
 - (void)chromeExecuteCommand:(id)sender;
 
 @end
 
 @implementation DonorWindow
 
 - (void)chromeExecuteCommand:(id)sender {
-  g_chrome_execute_command_sender = [sender retain];
+  g_chrome_execute_command_sender = sender;
 }
 
 @end
 
 namespace {
 
 // A helper to swizzle chromeExecuteCommand method on UIWindow.
 class ScopedWindowSwizzler {
  public:
   ScopedWindowSwizzler()
       : class_swizzler_([UIWindow class],
                         [DonorWindow class],
                         @selector(chromeExecuteCommand:)) {
     DCHECK(!g_chrome_execute_command_sender);
   }
 
   ~ScopedWindowSwizzler() {
-    [g_chrome_execute_command_sender release];
     g_chrome_execute_command_sender = nil;
   }
 
  private:
   base::mac::ScopedObjCClassSwizzler class_swizzler_;
 
   DISALLOW_COPY_AND_ASSIGN(ScopedWindowSwizzler);
 };
 
 // Returns a form that should be marked as an account creation form by local
@@ skipping 82 matching lines @@
                      &IsPasswordField),
       form.form_data.fields.end());
   return form;
 }
 
 // Test fixture for testing PasswordGenerationAgent.
 class PasswordGenerationAgentTest : public web::WebTestWithWebState {
  public:
   void SetUp() override {
     web::WebTestWithWebState::SetUp();
-    mock_js_suggestion_manager_.reset(
-        [[OCMockObject niceMockForClass:[JsSuggestionManager class]] retain]);
-    mock_js_password_manager_.reset(
-        [[OCMockObject niceMockForClass:[JsPasswordManager class]] retain]);
-    mock_ui_delegate_.reset([[MockPasswordsUiDelegate alloc] init]);
-    test_web_state_.reset(new web::TestWebState);
-    agent_.reset([[PasswordGenerationAgent alloc]
+    mock_js_suggestion_manager_ =
+        [OCMockObject niceMockForClass:[JsSuggestionManager class]];
+    mock_js_password_manager_ =
+        [OCMockObject niceMockForClass:[JsPasswordManager class]];
+    mock_ui_delegate_ = [[MockPasswordsUiDelegate alloc] init];
+    test_web_state_ = base::MakeUnique<web::TestWebState>();
+    agent_ = [[PasswordGenerationAgent alloc]
              initWithWebState:test_web_state_.get()
               passwordManager:nullptr
         passwordManagerDriver:nullptr
             JSPasswordManager:mock_js_password_manager_
           JSSuggestionManager:mock_js_suggestion_manager_
-          passwordsUiDelegate:mock_ui_delegate_]);
+          passwordsUiDelegate:mock_ui_delegate_];
     @autoreleasepool {
-      accessory_view_controller_.reset([[FormInputAccessoryViewController alloc]
+      accessory_view_controller_ = [[FormInputAccessoryViewController alloc]
           initWithWebState:test_web_state_.get()
-                 providers:@[ agent_ ]]);
+                 providers:@[ agent_ ]];
     }
   }
 
   // Sends form data, autofill data, and password manager data to the
   // generation agent so that it can find an account creation form and password
   // field.
   void LoadAccountCreationForm() {
     autofill::PasswordForm password_form(GetAccountCreationForm());
     [agent() allowPasswordGenerationForForm:password_form];
     std::vector<autofill::PasswordForm> password_forms;
@@ skipping 35 matching lines @@
   // Returns a mock of JsSuggestionManager.
   id mock_js_suggestion_manager() { return mock_js_suggestion_manager_; }
 
   // Returns a mock of JsPasswordManager.
   id mock_js_password_manager() { return mock_js_password_manager_; }
 
   MockPasswordsUiDelegate* mock_ui_delegate() { return mock_ui_delegate_; }
 
  protected:
   // Returns the current generation agent.
-  PasswordGenerationAgent* agent() { return agent_.get(); }
+  PasswordGenerationAgent* agent() { return agent_; }
 
   // Returns the current accessory view controller.
   FormInputAccessoryViewController* accessory_controller() {
-    return accessory_view_controller_.get();
+    return accessory_view_controller_;
   }
 
  private:
   // Test WebState.
   std::unique_ptr<web::TestWebState> test_web_state_;
 
   // Mock for JsSuggestionManager;
-  base::scoped_nsobject<id> mock_js_suggestion_manager_;
+  id mock_js_suggestion_manager_;
 
   // Mock for JsPasswordManager.
-  base::scoped_nsobject<id> mock_js_password_manager_;
+  id mock_js_password_manager_;
 
   // Mock for the UI delegate.
-  base::scoped_nsobject<MockPasswordsUiDelegate> mock_ui_delegate_;
+  MockPasswordsUiDelegate* mock_ui_delegate_;
 
   // Controller that shows custom input accessory views.
-  base::scoped_nsobject<FormInputAccessoryViewController>
-      accessory_view_controller_;
+  FormInputAccessoryViewController* accessory_view_controller_;
 
   // The current generation agent.
-  base::scoped_nsobject<PasswordGenerationAgent> agent_;
+  PasswordGenerationAgent* agent_;
 };
 
 // Tests that local heuristics skip forms with GAIA realm.
 TEST_F(PasswordGenerationAgentTest,
        OnParsedForms_ShouldIgnoreFormsWithGaiaRealm) {
   // Send only a form with GAIA origin to the agent.
   std::vector<autofill::PasswordForm> forms;
   forms.push_back(GetGAIAForm());
   [agent() processParsedPasswordForms:forms];
 
@@ skipping 149 matching lines @@
 // password.
 TEST_F(PasswordGenerationAgentTest,
        ShouldFillPasswordFieldAndDismissAlertWhenUserAcceptsGeneratedPassword) {
   LoadAccountCreationForm();
   // Focus the password field to start generation.
   SimulateFormActivity(kAccountCreationFormName, kAccountCreationFieldName,
                        @"focus");
   NSString* password = @"abc";
 
   [[[mock_js_password_manager() stub] andDo:^(NSInvocation* invocation) {
-    void (^completion_handler)(BOOL);
+    __unsafe_unretained void (^completion_handler)(BOOL);

[Eugene But (OOO till 7-30), 2016/12/07 18:21:35]

ditto

[stkhapugin, 2016/12/08 10:15:47]

See above. 

     [invocation getArgument:&completion_handler atIndex:4];
     completion_handler(YES);
   }] fillPasswordForm:kAccountCreationFormName
       withGeneratedPassword:password
           completionHandler:[OCMArg any]];
 
   [agent() generatePassword];
   EXPECT_EQ(YES, mock_ui_delegate().UIShown);
 
   [agent() acceptPasswordGeneration:nil];
@@ skipping 16 matching lines @@
   [agent() showSavedPasswords:nil];
   EXPECT_EQ(NO, mock_ui_delegate().UIShown);
 
   GenericChromeCommand* command = base::mac::ObjCCast<GenericChromeCommand>(
       g_chrome_execute_command_sender);
   EXPECT_TRUE(command);
   EXPECT_EQ(IDC_SHOW_SAVE_PASSWORDS_SETTINGS, command.tag);
 }
 
 }  // namespace