Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2559653002: Remove ContextLifecycleObserver from ActiveDOMCallback (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextLifecycleObserver from ActiveDOMCallback ActiveDOMCallback doesn't need to inherit from ContextLifecycleObserver. It should just hold a member pointer to ExecutionContext. BUG=610176 Committed: https://crrev.com/03043071bd52d307fc2f33c8d2c7a2090dc8f0ac Cr-Commit-Position: refs/heads/master@{#436893}

Patch Set 1 #

Total comments: 1

Messages

Total messages: 12 (7 generated)
haraken
PTAL This is a part of efforts to reduce # of ContextLifecycleObservers. Currently there're classes ...
4 years ago (2016-12-07 05:56:02 UTC) #2
sof
lgtm
4 years ago (2016-12-07 07:40:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559653002/1
4 years ago (2016-12-07 08:02:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 08:41:38 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-07 08:44:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03043071bd52d307fc2f33c8d2c7a2090dc8f0ac
Cr-Commit-Position: refs/heads/master@{#436893}

Powered by Google App Engine
This is Rietveld 408576698