Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.h

Issue 2559653002: Remove ContextLifecycleObserver from ActiveDOMCallback (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.h b/third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.h
index 63ed27f911660603d8d7d8bd8aef8536c031f411..b27429035349efca38c63b512f6992bb68202c14 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.h
@@ -32,7 +32,7 @@
#define ActiveDOMCallback_h
#include "core/CoreExport.h"
-#include "core/dom/ContextLifecycleObserver.h"
+#include "platform/heap/Handle.h"
namespace blink {
@@ -45,12 +45,17 @@ class ExecutionContext;
//
// Should only be created, used, and destroyed on the script execution
// context thread.
-class CORE_EXPORT ActiveDOMCallback : public ContextLifecycleObserver {
+class CORE_EXPORT ActiveDOMCallback : public GarbageCollectedMixin {
public:
explicit ActiveDOMCallback(ExecutionContext*);
virtual ~ActiveDOMCallback();
bool canInvokeCallback() const;
+
+ DECLARE_TRACE();
+
+ private:
+ Member<ExecutionContext> m_context;
haraken 2016/12/07 05:56:02 Before this CL, it was WeakMember. However, I don'
};
} // namespace blink
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698