Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.cpp

Issue 2559653002: Remove ContextLifecycleObserver from ActiveDOMCallback (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.cpp b/third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.cpp
index 6b80705bb8cab83dd27e12114eef41643a9af766..a9458246d169d99b64fbc26ac42d1d3c745aebd9 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.cpp
@@ -37,14 +37,17 @@
namespace blink {
ActiveDOMCallback::ActiveDOMCallback(ExecutionContext* context)
- : ContextLifecycleObserver(context) {}
+ : m_context(context) {}
ActiveDOMCallback::~ActiveDOMCallback() {}
bool ActiveDOMCallback::canInvokeCallback() const {
- ExecutionContext* context = getExecutionContext();
- return context && !context->activeDOMObjectsAreSuspended() &&
- !context->isContextDestroyed();
+ return !m_context->activeDOMObjectsAreSuspended() &&
+ !m_context->isContextDestroyed();
+}
+
+DEFINE_TRACE(ActiveDOMCallback) {
+ visitor->trace(m_context);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698