Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2559643004: Change layout item in CFWL_Widget type from void (Closed)

Created:
4 years ago by dsinclair
Modified:
4 years ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Change layout item in CFWL_Widget type from void Previously the LayoutItem was a void*. This Cl changes the LayoutItem to explicity be a CXFA_FFWidget. Committed: https://pdfium.googlesource.com/pdfium/+/89ab499024b1f362b1d40dabd9fadded8b095203

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -14 lines) Patch
M xfa/fwl/cfwl_edit.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/fwl/cfwl_widget.h View 3 chunks +4 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_fwladapter.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
dsinclair
PTAL. I'm guessing this was done originally because fwl/ could be used for things other ...
4 years ago (2016-12-08 18:32:10 UTC) #2
Tom Sepez
lgtm
4 years ago (2016-12-08 18:41:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559643004/1
4 years ago (2016-12-08 22:05:57 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-08 22:06:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/89ab499024b1f362b1d40dabd9fadded8b09...

Powered by Google App Engine
This is Rietveld 408576698