Change CFWL_Widget::GetMatrix to return the matrix

Change CFWL_Widget::GetMatrix to return the matrix

This CL switches to using a return value instead of an out parameter. The global
flag was also removed and the call sites changed to just SetIdentity as
appropriate.

Committed: https://pdfium.googlesource.com/pdfium/+/1babeeed9c259b9d486b4cbee949253769d18fff

[dsinclair, 2016-12-08 19:02:35]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 19:02:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-12-08 19:02:45]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-12-08 19:02:46]

PTAL.

https://codereview.chromium.org/2564443003/diff/1/xfa/fwl/cfwl_widget.cpp
File xfa/fwl/cfwl_widget.cpp (left):

https://codereview.chromium.org/2564443003/diff/1/xfa/fwl/cfwl_widget.cpp#old...
xfa/fwl/cfwl_widget.cpp:226: m1.SetIdentity();
CFX_Matrix constructor calls SetIdentity()

https://codereview.chromium.org/2564443003/diff/1/xfa/fwl/cfwl_widgetmgr.cpp
File xfa/fwl/cfwl_widgetmgr.cpp (left):

https://codereview.chromium.org/2564443003/diff/1/xfa/fwl/cfwl_widgetmgr.cpp#...
xfa/fwl/cfwl_widgetmgr.cpp:301: child->GetMatrix(matrixOnParent, false);
This would, at most, SetIdentity on the matrix, but that would also have just
happened given we just created it.

[Tom Sepez, 2016-12-08 19:23:07]

lgtm

https://codereview.chromium.org/2564443003/diff/20001/xfa/fwl/cfwl_widget.cpp
File xfa/fwl/cfwl_widget.cpp (left):

https://codereview.chromium.org/2564443003/diff/20001/xfa/fwl/cfwl_widget.cpp...
xfa/fwl/cfwl_widget.cpp:238: if (!bGlobal) {
really?  really? sigh.

https://codereview.chromium.org/2564443003/diff/20001/xfa/fwl/cfwl_widget.h
File xfa/fwl/cfwl_widget.h (right):

https://codereview.chromium.org/2564443003/diff/20001/xfa/fwl/cfwl_widget.h#n...
xfa/fwl/cfwl_widget.h:94: CFX_Matrix GetMatrix();
nit: is this const method?

[commit-bot: I haz the power, 2016-12-08 20:05:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 20:05:12]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-12-08 22:00:14]

PTAL.

The const had some ripples, had to add a const_cast, please take another look.

https://codereview.chromium.org/2564443003/diff/20001/xfa/fwl/cfwl_widget.h
File xfa/fwl/cfwl_widget.h (right):

https://codereview.chromium.org/2564443003/diff/20001/xfa/fwl/cfwl_widget.h#n...
xfa/fwl/cfwl_widget.h:94: CFX_Matrix GetMatrix();
On 2016/12/08 19:23:07, Tom Sepez wrote:
> nit: is this const method?

Done.

[Tom Sepez, 2016-12-09 00:29:23]

https://codereview.chromium.org/2564443003/diff/40001/xfa/fwl/cfwl_widget.h
File xfa/fwl/cfwl_widget.h (right):

https://codereview.chromium.org/2564443003/diff/40001/xfa/fwl/cfwl_widget.h#n...
xfa/fwl/cfwl_widget.h:164: CFWL_Widget* GetParent() const { return
m_pWidgetMgr->GetParentWidget(this); }
I think I'd be happier if we just left this non-const.

[dsinclair, 2016-12-09 03:43:36]

Patchset #3 (id:40001) has been deleted

[dsinclair, 2016-12-09 03:43:55]

On 2016/12/09 00:29:23, Tom Sepez wrote:
> https://codereview.chromium.org/2564443003/diff/40001/xfa/fwl/cfwl_widget.h
> File xfa/fwl/cfwl_widget.h (right):
> 
>
https://codereview.chromium.org/2564443003/diff/40001/xfa/fwl/cfwl_widget.h#n...
> xfa/fwl/cfwl_widget.h:164: CFWL_Widget* GetParent() const { return
> m_pWidgetMgr->GetParentWidget(this); }
> I think I'd be happier if we just left this non-const.

Deleted patchset, submitting ps#2

[dsinclair, 2016-12-09 03:44:38]

https://codereview.chromium.org/2564443003/diff/20001/xfa/fwl/cfwl_widget.h
File xfa/fwl/cfwl_widget.h (right):

https://codereview.chromium.org/2564443003/diff/20001/xfa/fwl/cfwl_widget.h#n...
xfa/fwl/cfwl_widget.h:94: CFX_Matrix GetMatrix();
On 2016/12/08 22:00:14, dsinclair wrote:
> On 2016/12/08 19:23:07, Tom Sepez wrote:
> > nit: is this const method?
> 
> Done.

Patchset deleted, ripples were not good.

[dsinclair, 2016-12-09 03:44:42]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-12-09 03:44:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 03:45:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481255082005400,
"parent_rev": "94afac986c9d6232b7791acff4f23d99fbd004ae", "commit_rev":
"1babeeed9c259b9d486b4cbee949253769d18fff"}

[commit-bot: I haz the power, 2016-12-09 03:45:04]

Description was changed from

==========
Change CFWL_Widget::GetMatrix to return the matrix

This CL switches to using a return value instead of an out parameter. The global
flag was also removed and the call sites changed to just SetIdentity as
appropriate.
==========

to

==========
Change CFWL_Widget::GetMatrix to return the matrix

This CL switches to using a return value instead of an out parameter. The global
flag was also removed and the call sites changed to just SetIdentity as
appropriate.

Committed:
https://pdfium.googlesource.com/pdfium/+/1babeeed9c259b9d486b4cbee949253769d1...
==========

[commit-bot: I haz the power, 2016-12-09 03:45:05]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/1babeeed9c259b9d486b4cbee949253769d1...