Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2559463004: install-build-deps: install locales using locale-gen (Closed)

Created:
4 years ago by Tom (Use chromium acct)
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

install-build-deps: install locales using locale-gen Previously we were installing Ubuntu language packs to just for their locales. According to apt, these packages took up ~25Mb of space, and the packages are not available on Debian. This CL uses locale-gen to generate the needed locales instead. The locales are only needed in the following tests: fr_FR.UTF-8: TimeFormatBrowserTest.DecimalPointNotDot da_DK.UTF-8: LocaleTestDanish.TestStart he_IL.UTF-8: LocaleTestHebrew.TestStart zh_TW.UTF-8: LocaleTestTraditionalChinese.TestStart R=dpranke@chromium.org Committed: https://crrev.com/5ef5c3d2c48d8ae8cb9b90376649688b35ce2057 Cr-Commit-Position: refs/heads/master@{#437136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -11 lines) Patch
M build/install-build-deps.sh View 2 chunks +30 lines, -11 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Tom (Use chromium acct)
This is CL#2
4 years ago (2016-12-07 18:48:31 UTC) #2
Dirk Pranke
lgtm
4 years ago (2016-12-07 23:52:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559463004/20001
4 years ago (2016-12-07 23:54:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-08 01:59:55 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-08 02:02:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ef5c3d2c48d8ae8cb9b90376649688b35ce2057
Cr-Commit-Position: refs/heads/master@{#437136}

Powered by Google App Engine
This is Rietveld 408576698