Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2556133003: Add jessie support to install-build-deps.sh (Closed)

Created:
4 years ago by Tom (Use chromium acct)
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add jessie support to install-build-deps.sh This CL - Enables jessie support in install-build-deps.sh - Adds a note in linux_build_instructions.md about adding the 'contrib' component in sources.list. - Fixes a bug in package_exists where if a ppa is added, a package is installed from it, and then the ppa is removed, and the package is removed but not purged, package_exists would still return true for the package. R=dpranke@chromium.org Committed: https://crrev.com/b4a2bcaef478f19b5a244d5102b412dea5372ecd Cr-Commit-Position: refs/heads/master@{#437198}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename, update error message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -18 lines) Patch
M build/install-build-deps.sh View 1 4 chunks +13 lines, -10 lines 0 comments Download
M docs/linux_build_instructions.md View 1 chunk +28 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (12 generated)
Tom (Use chromium acct)
This is the 3rd and final CL to get jessie support in install-build-deps.sh
4 years ago (2016-12-07 23:25:02 UTC) #1
Dirk Pranke
lgtm w/ comments addressed. https://codereview.chromium.org/2556133003/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/2556133003/diff/1/build/install-build-deps.sh#newcode114 build/install-build-deps.sh:114: ubuntu_codenames="(precise|trusty|utopic|vivid|wily|xenial|jessie)" since jessie is a ...
4 years ago (2016-12-07 23:43:23 UTC) #4
Tom (Use chromium acct)
On 2016/12/07 23:43:23, Dirk Pranke wrote: > lgtm w/ comments addressed. > Thanks. Can you ...
4 years ago (2016-12-07 23:50:07 UTC) #7
Tom (Use chromium acct)
https://codereview.chromium.org/2556133003/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/2556133003/diff/1/build/install-build-deps.sh#newcode114 build/install-build-deps.sh:114: ubuntu_codenames="(precise|trusty|utopic|vivid|wily|xenial|jessie)" On 2016/12/07 23:43:23, Dirk Pranke wrote: > since ...
4 years ago (2016-12-08 01:31:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556133003/20001
4 years ago (2016-12-08 06:41:34 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 06:46:32 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-08 06:48:11 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b4a2bcaef478f19b5a244d5102b412dea5372ecd
Cr-Commit-Position: refs/heads/master@{#437198}

Powered by Google App Engine
This is Rietveld 408576698