Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Issue 2553853002: install-build-deps: support debian armhf packages (Closed)

Created:
4 years ago by Tom (Use chromium acct)
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

install-build-deps: support debian armhf packages R=dpranke@chromium.org Committed: https://crrev.com/4e3d30fe2c702f521b7939ac0b040f36dc07260c Cr-Commit-Position: refs/heads/master@{#437020}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add g++ cross compiler #

Patch Set 3 : Add quotes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -42 lines) Patch
M build/install-build-deps.sh View 1 2 4 chunks +81 lines, -42 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
Tom (Use chromium acct)
dpranke@ PTAL This will be the first of 3 CLs to support install-build-deps.sh on jessie. ...
4 years ago (2016-12-05 20:38:20 UTC) #1
Dirk Pranke
lgtm https://codereview.chromium.org/2553853002/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/2553853002/diff/1/build/install-build-deps.sh#newcode156 build/install-build-deps.sh:156: jessie) I think it might be more conventional ...
4 years ago (2016-12-06 02:21:20 UTC) #2
Tom (Use chromium acct)
dpranke@ please take another look. I added the Debian cross tools repo as we discussed ...
4 years ago (2016-12-07 18:29:54 UTC) #3
Dirk Pranke
lgtm
4 years ago (2016-12-07 18:38:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553853002/40001
4 years ago (2016-12-07 18:44:53 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-07 18:59:02 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-07 19:01:07 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4e3d30fe2c702f521b7939ac0b040f36dc07260c
Cr-Commit-Position: refs/heads/master@{#437020}

Powered by Google App Engine
This is Rietveld 408576698