Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2559433003: PPC: Split kPPC_Add into kPPC_Add[32|64] (Closed)

Created:
4 years ago by JaideepBajwa
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Split kPPC_Add into kPPC_Add[32|64] R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Committed: https://crrev.com/f7f817d7833d24e4f3b678bfe32fd22188a56ab1 Cr-Commit-Position: refs/heads/master@{#41536}

Patch Set 1 #

Patch Set 2 : extsw outside the if/else block #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -12 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 4 chunks +21 lines, -3 lines 0 comments Download
M src/compiler/ppc/instruction-codes-ppc.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/ppc/instruction-scheduler-ppc.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
JaideepBajwa
ptal
4 years ago (2016-12-06 18:38:03 UTC) #1
john.yan
lgtm
4 years ago (2016-12-06 18:55:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559433003/20001
4 years ago (2016-12-06 18:56:21 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 19:26:37 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-06 19:26:55 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f7f817d7833d24e4f3b678bfe32fd22188a56ab1
Cr-Commit-Position: refs/heads/master@{#41536}

Powered by Google App Engine
This is Rietveld 408576698