Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2559213002:
Add suppression for GPU Pixel test in preparation for Skia CL (Closed)
|
Created:
4 years ago by robertphillips Modified:
4 years ago CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd suppression for GPU Pixel test in preparation for Skia CL
BUG=672527
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/2c4b5bc559986fa911cd1b847ce19cdbeb1dcff5
Cr-Commit-Position: refs/heads/master@{#437530}
Patch Set 1 #
Total comments: 1
Patch Set 2 : add TODO #Messages
Total messages: 19 (11 generated)
Description was changed from ========== Add suppression for GPU Pixel test in preparation for Skia CL BUG=672527 ========== to ========== Add suppression for GPU Pixel test in preparation for Skia CL BUG=672527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Description was changed from ========== Add suppression for GPU Pixel test in preparation for Skia CL BUG=672527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Add suppression for GPU Pixel test in preparation for Skia CL BUG=672527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
robertphillips@google.com changed reviewers: + fmalita@chromium.org, reed@chromium.org, reed@google.com
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
robertphillips@google.com changed reviewers: + kbr@chromium.org
https://codereview.chromium.org/2559213002/diff/1/content/test/gpu/gpu_tests/... File content/test/gpu/gpu_tests/pixel_expectations.py (right): https://codereview.chromium.org/2559213002/diff/1/content/test/gpu/gpu_tests/... content/test/gpu/gpu_tests/pixel_expectations.py:15: self.Fail('Pixel_CSSFilterEffects', bug=672527) I'm not familiar with gpu pixel tests -- is Fail the right expectation here? Immediately after this lands, the test will still pass, so maybe we should use Flaky or Skip instead? I guess we'll see if the bots complain. You'll also need a content/ owner to approve this, so I'm deferring to them.
On 2016/12/08 17:23:41, f(malita) wrote: > https://codereview.chromium.org/2559213002/diff/1/content/test/gpu/gpu_tests/... > File content/test/gpu/gpu_tests/pixel_expectations.py (right): > > https://codereview.chromium.org/2559213002/diff/1/content/test/gpu/gpu_tests/... > content/test/gpu/gpu_tests/pixel_expectations.py:15: > self.Fail('Pixel_CSSFilterEffects', bug=672527) > I'm not familiar with gpu pixel tests -- is Fail the right expectation here? > Immediately after this lands, the test will still pass, so maybe we should use > Flaky or Skip instead? I guess we'll see if the bots complain. > > You'll also need a content/ owner to approve this, so I'm deferring to them. Robert pointed out that this is the documented process: http://www.chromium.org/developers/testing/gpu-testing#TOC-Updating-and-Addin... Non-owner LGTM
robertphillips@google.com changed reviewers: + bajones@chromium.org
LGTM I assume you'll increment the revision number for this test after the Skia roll.
> I assume you'll increment the revision number for this test after the Skia roll. Right, and then remove the suppression here.
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481286964737130,
"parent_rev": "a09df4850f966164a1ea179dfb3de7c9e519445c", "commit_rev":
"3e24247b47fe9d76962c00eb2dffe01a6b9e5160"}
Message was sent while issue was closed.
Description was changed from ========== Add suppression for GPU Pixel test in preparation for Skia CL BUG=672527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Add suppression for GPU Pixel test in preparation for Skia CL BUG=672527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2559213002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add suppression for GPU Pixel test in preparation for Skia CL BUG=672527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2559213002 ========== to ========== Add suppression for GPU Pixel test in preparation for Skia CL BUG=672527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/2c4b5bc559986fa911cd1b847ce19cdbeb1dcff5 Cr-Commit-Position: refs/heads/master@{#437530} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2c4b5bc559986fa911cd1b847ce19cdbeb1dcff5 Cr-Commit-Position: refs/heads/master@{#437530} |
