Password bubble: Create subviews for ManagePasswordsBubbleView.

chrome/browser/ui/passwords/manage_passwords_bubble.h

Index: chrome/browser/ui/passwords/manage_passwords_bubble.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble.h b/chrome/browser/ui/passwords/manage_passwords_bubble.h
index f759ea9402032952a4ed5f2802b0e9bb12294dd0..ffdb5c8bb2ccbb55799927a1337dd87d4bd23c85 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble.h
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble.h
@@ -29,7 +29,7 @@ class ManagePasswordsBubble {
   ManagePasswordsBubble(content::WebContents* contents, DisplayReason reason);
   ~ManagePasswordsBubble();
 
-  ManagePasswordsBubbleModel* model() { return model_.get(); }
+  ManagePasswordsBubbleModel* model() const { return model_.get(); }

[vabr (Chromium), 2014/04/28 13:17:38]

I still mean my previous comment [1] :). Or, as Peter put it: "const methods
should not return non-const pointers" [2].

[1]
https://codereview.chromium.org/232753002/diff/1/chrome/browser/ui/passwords/...
[2]
https://codereview.chromium.org/246393004/diff/70001/chrome/browser/ui/views/...

[Mike West, 2014/04/28 14:02:27]

Hrm. I apparently _really_ want this to be const. :/

 
  private:
   scoped_ptr<ManagePasswordsBubbleModel> model_;