Password bubble: Introduce a command to open the bubble.

chrome/browser/ui/views/passwords/manage_passwords_view_test.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_VIEW_TEST_H_
+#define CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_VIEW_TEST_H_
+
+#include "chrome/test/base/in_process_browser_test.h"
+#include "components/autofill/core/common/password_form.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class ManagePasswordsBubbleUIControllerMock;
+class ManagePasswordsIconView;
+
+// Test class for the various password management view bits and pieces. Sets
+// up a ManagePasswordsBubbleUIControllerMock, and provides some helper methods
+// to poke at the bubble, icon, and controller's state.
+class ManagePasswordsViewTest : public InProcessBrowserTest {
+ public:
+  enum Expectation { EXPECT_SUCCESS, EXPECT_FAILURE };
+
+  ManagePasswordsViewTest() {}
+
+  // InProcessBrowserTest:
+  virtual void SetUpOnMainThread() OVERRIDE;
+
+  // Get the mock UI controller for the current WebContents.
+  ManagePasswordsBubbleUIControllerMock* controller();
+
+  // Get the icon view for the current WebContents.
+  ManagePasswordsIconView* view() const;

[Peter Kasting, 2014/04/25 22:12:02]

Const methods must not return non-const pointers.

[Mike West, 2014/04/28 10:52:56]

Done.

+
+  // Execute the browser command to open the manage passwords bubble.
+  void ExecuteManagePasswordsCommand(Expectation expectation = EXPECT_SUCCESS);

[vabr (Chromium), 2014/04/25 15:26:17]

optional nit: This read a bit strangely in the test above, when the
EXPECT_FAILURE was made explicit, and the EXPECT_SUCCESS was not mentioned.
I would suggest either
1) not using implicit arguments, and always write EXPECT_SUCCESS, or
2) (if the above would make lines too long) provide two versions of this method
(distinguished, e.g., by a short suffix -Success, -Error), which would
internally call the original method with the right argument.

+
+  // Put the controller, icon, and bubble into a managing-password state.
+  void SetupManagingPasswords();
+
+  // Put the controller, icon, and bubble into a pending-password state.
+  void SetupPendingPassword();
+
+  autofill::PasswordForm& test_form() { return test_form_; }

[Peter Kasting, 2014/04/25 22:12:02]

Nit: Don't return by non-const ref.  Return a const ref (and make the function
const) or return a pointer.

[Mike West, 2014/04/28 10:52:56]

Done.

+
+ private:
+  autofill::PasswordForm test_form_;
+
+  DISALLOW_COPY_AND_ASSIGN(ManagePasswordsViewTest);
+};
+
+#endif  // CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_VIEW_TEST_H_