Password bubble: Create subviews for ManagePasswordsBubbleView.

chrome/browser/ui/passwords/manage_passwords_bubble.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_H_
 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_H_
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "components/password_manager/core/browser/password_manager_metrics_util.h"
@@ skipping 11 matching lines @@
  public:
   enum DisplayReason { AUTOMATIC, USER_ACTION };
 
  protected:
   // Creates a ManagePasswordsBubble. |contents| is used only to create a
   // ManagePasswordsBubbleModel; this class neither takes ownership of the
   // object nor stores the pointer.
   ManagePasswordsBubble(content::WebContents* contents, DisplayReason reason);
   ~ManagePasswordsBubble();
 
-  ManagePasswordsBubbleModel* model() { return model_.get(); }
+  ManagePasswordsBubbleModel* model() const { return model_.get(); }

[vabr (Chromium), 2014/04/28 13:17:38]

I still mean my previous comment [1] :). Or, as Peter put it: "const methods
should not return non-const pointers" [2].

[1]
https://codereview.chromium.org/232753002/diff/1/chrome/browser/ui/passwords/...
[2]
https://codereview.chromium.org/246393004/diff/70001/chrome/browser/ui/views/...

[Mike West, 2014/04/28 14:02:27]

Hrm. I apparently _really_ want this to be const. :/

 
  private:
   scoped_ptr<ManagePasswordsBubbleModel> model_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubble);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_H_