|
|
DescriptionAdd milestone to deprecation message for EME on insecure contexts
Intent to Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tXmKPlXsnCQ
BUG=672605
Committed: https://crrev.com/810fa54c3422d6f7e3666506ee8cd3b84b9b2c82
Cr-Commit-Position: refs/heads/master@{#439244}
Patch Set 1 #
Total comments: 3
Patch Set 2 : Add specific milestone #Patch Set 3 : Update expected console warning. #Patch Set 4 : rebase only #
Messages
Total messages: 29 (17 generated)
Description was changed from ========== Add date to deprecation message for EME on insecure contexts BUG=672605 ========== to ========== Add date to deprecation message for EME on insecure contexts Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tXmKPlXsnCQ BUG=672605 ==========
ddorwin@chromium.org changed reviewers: + foolip@chromium.org, xhwang@chromium.org
lgtm
lgtm https://codereview.chromium.org/2558813007/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/2558813007/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/frame/Deprecation.cpp:334: "in the specification. Support will be removed at the end of Q1 " Can you say which milestone it will be? The state will still be a bit vague, but this way you know when you can test for it in the pre-stable channels.
The CQ bit was checked by ddorwin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by foolip@chromium.org
https://codereview.chromium.org/2558813007/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/2558813007/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/frame/Deprecation.cpp:334: "in the specification. Support will be removed at the end of Q1 " On 2016/12/13 11:06:01, foolip wrote: > Can you say which milestone it will be? The state will still be a bit vague, but > this way you know when you can test for it in the pre-stable channels. Unchecked CQ to see this addressed. (Should have said lgtm % nits, sorry.)
https://codereview.chromium.org/2558813007/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/2558813007/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/frame/Deprecation.cpp:334: "in the specification. Support will be removed at the end of Q1 " On 2016/12/13 23:07:34, foolip wrote: > On 2016/12/13 11:06:01, foolip wrote: > > Can you say which milestone it will be? The state will still be a bit vague, > but > > this way you know when you can test for it in the pre-stable channels. > > Unchecked CQ to see this addressed. (Should have said lgtm % nits, sorry.) Done. Apologies for missing this comment.
The CQ bit was checked by ddorwin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
lgtm
The CQ bit was checked by ddorwin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org, foolip@chromium.org Link to the patchset: https://codereview.chromium.org/2558813007/#ps40001 (title: "Update expected console warning.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
Description was changed from ========== Add date to deprecation message for EME on insecure contexts Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tXmKPlXsnCQ BUG=672605 ========== to ========== Add milestone to deprecation message for EME on insecure contexts Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tXmKPlXsnCQ BUG=672605 ==========
The CQ bit was checked by ddorwin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org, foolip@chromium.org Link to the patchset: https://codereview.chromium.org/2558813007/#ps60001 (title: "rebase only")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481912761244420, "parent_rev": "dab0af05eea6ccf3c1db4e39d4f9f4795aedbbe8", "commit_rev": "dff6551918283f9dd48f558931a6a6498d926d28"}
Message was sent while issue was closed.
Description was changed from ========== Add milestone to deprecation message for EME on insecure contexts Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tXmKPlXsnCQ BUG=672605 ========== to ========== Add milestone to deprecation message for EME on insecure contexts Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tXmKPlXsnCQ BUG=672605 Review-Url: https://codereview.chromium.org/2558813007 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Add milestone to deprecation message for EME on insecure contexts Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tXmKPlXsnCQ BUG=672605 Review-Url: https://codereview.chromium.org/2558813007 ========== to ========== Add milestone to deprecation message for EME on insecure contexts Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tXmKPlXsnCQ BUG=672605 Committed: https://crrev.com/810fa54c3422d6f7e3666506ee8cd3b84b9b2c82 Cr-Commit-Position: refs/heads/master@{#439244} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/810fa54c3422d6f7e3666506ee8cd3b84b9b2c82 Cr-Commit-Position: refs/heads/master@{#439244} |