Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2558813007: Add milestone to deprecation message for EME on insecure contexts (Closed)

Created:
4 years ago by ddorwin
Modified:
4 years ago
Reviewers:
xhwang, foolip
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add milestone to deprecation message for EME on insecure contexts Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tXmKPlXsnCQ BUG=672605 Committed: https://crrev.com/810fa54c3422d6f7e3666506ee8cd3b84b9b2c82 Cr-Commit-Position: refs/heads/master@{#439244}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add specific milestone #

Patch Set 3 : Update expected console warning. #

Patch Set 4 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 2 3 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 29 (17 generated)
ddorwin
4 years ago (2016-12-10 01:52:47 UTC) #3
xhwang
lgtm
4 years ago (2016-12-10 03:57:38 UTC) #4
foolip
lgtm https://codereview.chromium.org/2558813007/diff/1/third_party/WebKit/Source/core/frame/Deprecation.cpp File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/2558813007/diff/1/third_party/WebKit/Source/core/frame/Deprecation.cpp#newcode334 third_party/WebKit/Source/core/frame/Deprecation.cpp:334: "in the specification. Support will be removed at ...
4 years ago (2016-12-13 11:06:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558813007/1
4 years ago (2016-12-13 22:58:50 UTC) #7
foolip
https://codereview.chromium.org/2558813007/diff/1/third_party/WebKit/Source/core/frame/Deprecation.cpp File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/2558813007/diff/1/third_party/WebKit/Source/core/frame/Deprecation.cpp#newcode334 third_party/WebKit/Source/core/frame/Deprecation.cpp:334: "in the specification. Support will be removed at the ...
4 years ago (2016-12-13 23:07:34 UTC) #9
ddorwin
https://codereview.chromium.org/2558813007/diff/1/third_party/WebKit/Source/core/frame/Deprecation.cpp File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/2558813007/diff/1/third_party/WebKit/Source/core/frame/Deprecation.cpp#newcode334 third_party/WebKit/Source/core/frame/Deprecation.cpp:334: "in the specification. Support will be removed at the ...
4 years ago (2016-12-16 02:15:41 UTC) #10
foolip
lgtm
4 years ago (2016-12-16 10:22:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558813007/40001
4 years ago (2016-12-16 17:55:54 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/124395) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-16 17:57:45 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558813007/60001
4 years ago (2016-12-16 18:26:39 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-17 00:12:51 UTC) #27
commit-bot: I haz the power
4 years ago (2016-12-17 00:16:52 UTC) #29
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/810fa54c3422d6f7e3666506ee8cd3b84b9b2c82
Cr-Commit-Position: refs/heads/master@{#439244}

Powered by Google App Engine
This is Rietveld 408576698