Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2558813007: Add milestone to deprecation message for EME on insecure contexts (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/frame/Deprecation.h" 5 #include "core/frame/Deprecation.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/dom/ExecutionContext.h" 8 #include "core/dom/ExecutionContext.h"
9 #include "core/frame/FrameConsole.h" 9 #include "core/frame/FrameConsole.h"
10 #include "core/frame/FrameHost.h" 10 #include "core/frame/FrameHost.h"
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 324
325 case UseCounter::GetUserMediaInsecureOrigin: 325 case UseCounter::GetUserMediaInsecureOrigin:
326 case UseCounter::GetUserMediaInsecureOriginIframe: 326 case UseCounter::GetUserMediaInsecureOriginIframe:
327 return "getUserMedia() no longer works on insecure origins. To use this " 327 return "getUserMedia() no longer works on insecure origins. To use this "
328 "feature, you should consider switching your application to a " 328 "feature, you should consider switching your application to a "
329 "secure origin, such as HTTPS. See https://goo.gl/rStTGz for more " 329 "secure origin, such as HTTPS. See https://goo.gl/rStTGz for more "
330 "details."; 330 "details.";
331 331
332 case UseCounter::EncryptedMediaInsecureOrigin: 332 case UseCounter::EncryptedMediaInsecureOrigin:
333 return "requestMediaKeySystemAccess() is deprecated on insecure origins " 333 return "requestMediaKeySystemAccess() is deprecated on insecure origins "
334 "in the specification. Support will be removed in the future. You " 334 "in the specification. Support will be removed at the end of Q1 "
foolip 2016/12/13 11:06:01 Can you say which milestone it will be? The state
foolip 2016/12/13 23:07:34 Unchecked CQ to see this addressed. (Should have s
ddorwin 2016/12/16 02:15:41 Done. Apologies for missing this comment.
335 "should consider switching your application to a secure origin, " 335 "2017. You should consider switching your application to a secure "
336 "such as HTTPS. See https://goo.gl/rStTGz for more details."; 336 "origin, such as HTTPS. See https://goo.gl/rStTGz for more "
337 "details.";
337 338
338 case UseCounter::MediaSourceAbortRemove: 339 case UseCounter::MediaSourceAbortRemove:
339 return "Using SourceBuffer.abort() to abort remove()'s asynchronous " 340 return "Using SourceBuffer.abort() to abort remove()'s asynchronous "
340 "range removal is deprecated due to specification change. Support " 341 "range removal is deprecated due to specification change. Support "
341 "will be removed in the future. You should instead await " 342 "will be removed in the future. You should instead await "
342 "'updateend'. abort() is intended to only abort an asynchronous " 343 "'updateend'. abort() is intended to only abort an asynchronous "
343 "media append or reset parser state. See " 344 "media append or reset parser state. See "
344 "https://www.chromestatus.com/features/6107495151960064 for more " 345 "https://www.chromestatus.com/features/6107495151960064 for more "
345 "details."; 346 "details.";
346 case UseCounter::MediaSourceDurationTruncatingBuffered: 347 case UseCounter::MediaSourceDurationTruncatingBuffered:
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
414 return willBeRemoved("HTMLObjectElement legacy caller", M58, 415 return willBeRemoved("HTMLObjectElement legacy caller", M58,
415 "5715026367217664"); 416 "5715026367217664");
416 417
417 // Features that aren't deprecated don't have a deprecation message. 418 // Features that aren't deprecated don't have a deprecation message.
418 default: 419 default:
419 return String(); 420 return String();
420 } 421 }
421 } 422 }
422 423
423 } // namespace blink 424 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698