Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Issue 2558653002: [turbofan] Add --csa-verify flag that enables machine graph verification of code stubs. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add --csa-verify flag that enables machine graph verification of code stubs. The flag must be used only by CodeStubAssemblerGraphsCorrectness cctest for now and once all the verification issues are fixed the flag will be enabled in debug mode by default. This CL also relaxes some checks for code stub graphs and fixes some issues in the stubs. BUG= Committed: https://crrev.com/df2f66e01e2310a94e48ae5178e1a557e22f7ae5 Cr-Commit-Position: refs/heads/master@{#41547}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -27 lines) Patch
M src/code-stub-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/machine-graph-verifier.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/machine-graph-verifier.cc View 9 chunks +62 lines, -16 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/accessor-assembler.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 chunk +35 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (14 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-07 09:38:28 UTC) #11
epertoso
lgtm
4 years ago (2016-12-07 09:53:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558653002/20001
4 years ago (2016-12-07 10:38:52 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-07 10:40:49 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-07 10:41:12 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df2f66e01e2310a94e48ae5178e1a557e22f7ae5
Cr-Commit-Position: refs/heads/master@{#41547}

Powered by Google App Engine
This is Rietveld 408576698