Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2560663002: [stubs] Fix issues found by the machine graph verifier in load/store IC stubs. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Fix issues found by the machine graph verifier in load/store IC stubs. BUG= Committed: https://crrev.com/36807f8a2131265f91bd5301f819cd6211d4cf3c Cr-Commit-Position: refs/heads/master@{#41548}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -106 lines) Patch
M src/code-stub-assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 5 chunks +11 lines, -7 lines 0 comments Download
M src/ic/accessor-assembler.cc View 7 chunks +106 lines, -99 lines 2 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (16 generated)
Igor Sheludko
PTAL https://codereview.chromium.org/2560663002/diff/40001/src/ic/accessor-assembler.cc File src/ic/accessor-assembler.cc (left): https://codereview.chromium.org/2560663002/diff/40001/src/ic/accessor-assembler.cc#oldcode1517 src/ic/accessor-assembler.cc:1517: var_handler.Bind(IntPtrConstant(0)); I moved |miss| label to outer scope ...
4 years ago (2016-12-07 10:20:42 UTC) #11
epertoso
lgtm
4 years ago (2016-12-07 10:34:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560663002/40001
4 years ago (2016-12-07 10:55:12 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years ago (2016-12-07 10:57:12 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-07 10:57:50 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36807f8a2131265f91bd5301f819cd6211d4cf3c
Cr-Commit-Position: refs/heads/master@{#41548}

Powered by Google App Engine
This is Rietveld 408576698