Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2551353003: [stubs] Ensure that the stubs are recompiled in respective tests. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Ensure that the stubs are recompiled in respective tests. Removing elements from stub cache by Major key only does not always work. BUG= Committed: https://crrev.com/331b0df6e450b5dc3a6eadedea7ef822d1c0353a Cr-Commit-Position: refs/heads/master@{#41544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -44 lines) Patch
M src/code-stubs.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +55 lines, -44 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (14 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-06 18:35:35 UTC) #4
Camillo Bruni
lgtm
4 years ago (2016-12-07 10:20:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551353003/20001
4 years ago (2016-12-07 10:21:11 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-07 10:22:47 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-07 10:23:39 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/331b0df6e450b5dc3a6eadedea7ef822d1c0353a
Cr-Commit-Position: refs/heads/master@{#41544}

Powered by Google App Engine
This is Rietveld 408576698