Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2558243002: Add Http2FrameDecoderAdapter. (Closed)

Created:
4 years ago by Bence
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Http2FrameDecoderAdapter. This lands server change 127437330 by jamessynge. BUG=488484 Committed: https://crrev.com/7038e9c553aa1c4ef93449d94e038497bb7ff8d6 Cr-Commit-Position: refs/heads/master@{#437630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1051 lines, -17 lines) Patch
M net/net.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A net/spdy/http2_frame_decoder_adapter.h View 1 chunk +24 lines, -0 lines 0 comments Download
A net/spdy/http2_frame_decoder_adapter.cc View 1 chunk +976 lines, -0 lines 0 comments Download
M net/spdy/spdy_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_flags.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer_decoder_adapter.h View 2 chunks +7 lines, -6 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 5 chunks +22 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Bence
Ryan: PTAL. Thank you.
4 years ago (2016-12-08 13:20:41 UTC) #6
Ryan Hamilton
lgtm
4 years ago (2016-12-09 17:28:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558243002/1
4 years ago (2016-12-09 17:36:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 20:38:48 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 14:40:02 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7038e9c553aa1c4ef93449d94e038497bb7ff8d6
Cr-Commit-Position: refs/heads/master@{#437630}

Powered by Google App Engine
This is Rietveld 408576698