Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: net/spdy/spdy_framer_decoder_adapter.h

Issue 2558243002: Add Http2FrameDecoderAdapter. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_framer.cc ('k') | net/spdy/spdy_framer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_framer_decoder_adapter.h
diff --git a/net/spdy/spdy_framer_decoder_adapter.h b/net/spdy/spdy_framer_decoder_adapter.h
index 4c08c53b6385c4024afaff2dff6072d46077d781..20b70f647ab20e2d80458c6d18d02c083bd24824 100644
--- a/net/spdy/spdy_framer_decoder_adapter.h
+++ b/net/spdy/spdy_framer_decoder_adapter.h
@@ -54,9 +54,10 @@ class SpdyFramerDecoderAdapter {
return process_single_input_frame_;
}
- // Decode the |len| bytes of encoded HTTP/2 starting at |*data|. Returns the
- // number of bytes consumed. It is safe to pass more bytes in than may be
- // consumed.
+ // Decode the |len| bytes of encoded HTTP/2 starting at |*data|. Returns
+ // the number of bytes consumed. It is safe to pass more bytes in than
+ // may be consumed. Should process (or otherwise buffer) as much as
+ // available, unless process_single_input_frame is true.
virtual size_t ProcessInput(const char* data, size_t len) = 0;
// Reset the decoder (used just for tests at this time).
@@ -68,9 +69,9 @@ class SpdyFramerDecoderAdapter {
// Current error code (NO_ERROR if state != ERROR).
virtual SpdyFramer::SpdyError error_code() const = 0;
- // Did the most recently decoded frame header appear to be the start of an
- // HTTP/1.1 (or earlier) response? Used to detect if a backend/server that
- // we sent a request to, responded with an HTTP/1.1 response?
+ // Has any frame header looked like the start of an HTTP/1.1 (or earlier)
+ // response? Used to detect if a backend/server that we sent a request to
+ // has responded with an HTTP/1.1 (or earlier) response.
virtual bool probable_http_response() const = 0;
private:
« no previous file with comments | « net/spdy/spdy_framer.cc ('k') | net/spdy/spdy_framer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698