Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2558083005: Remove "top_down" flag in the message center code (Closed)

Created:
4 years ago by yoshiki
Modified:
4 years ago
Reviewers:
dewittj
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "top_down" flag in the message center code BUG=672392 TEST=trybots pass Committed: https://crrev.com/1a656aba25e1ca5aafa5960763cc79f42f4bcf29 Cr-Commit-Position: refs/heads/master@{#437595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -30 lines) Patch
M ui/message_center/views/message_center_bubble.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/message_center/views/message_center_view.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/message_center/views/message_center_view.cc View 4 chunks +8 lines, -13 lines 0 comments Download
M ui/message_center/views/message_center_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_list_view.h View 2 chunks +1 line, -2 lines 0 comments Download
M ui/message_center/views/message_list_view.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M ui/message_center/views/message_list_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
yoshiki
Justin, PTAL. Thanks.
4 years ago (2016-12-09 07:58:21 UTC) #7
dewittj
lgtm
4 years ago (2016-12-09 18:17:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558083005/1
4 years ago (2016-12-09 18:18:13 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 18:46:11 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-12 14:36:31 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a656aba25e1ca5aafa5960763cc79f42f4bcf29
Cr-Commit-Position: refs/heads/master@{#437595}

Powered by Google App Engine
This is Rietveld 408576698