Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: ui/message_center/views/message_list_view.cc

Issue 2558083005: Remove "top_down" flag in the message center code (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/views/message_list_view.h ('k') | ui/message_center/views/message_list_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/views/message_list_view.cc
diff --git a/ui/message_center/views/message_list_view.cc b/ui/message_center/views/message_list_view.cc
index 055a7bed3e8b06e5abea52d4b6b80b689bf3338e..f9ef2735240d38eeac658546893134b0c4a9b623 100644
--- a/ui/message_center/views/message_list_view.cc
+++ b/ui/message_center/views/message_list_view.cc
@@ -23,12 +23,11 @@ namespace {
const int kAnimateClearingNextNotificationDelayMS = 40;
} // namespace
-MessageListView::MessageListView(bool top_down)
+MessageListView::MessageListView()
: reposition_top_(-1),
fixed_height_(0),
has_deferred_task_(false),
clear_all_started_(false),
- top_down_(top_down),
animator_(this),
quit_message_loop_after_animation_for_test_(false),
weak_ptr_factory_(this) {
@@ -45,9 +44,9 @@ MessageListView::MessageListView(bool top_down)
set_background(
views::Background::CreateSolidBackground(kMessageCenterBackgroundColor));
SetBorder(views::CreateEmptyBorder(
- top_down ? 0 : kMarginBetweenItems - shadow_insets.top(), /* top */
- kMarginBetweenItems - shadow_insets.left(), /* left */
- top_down ? kMarginBetweenItems - shadow_insets.bottom() : 0, /* bottom */
+ kMarginBetweenItems - shadow_insets.top(), /* top */
+ kMarginBetweenItems - shadow_insets.left(), /* left */
+ 0, /* bottom */
kMarginBetweenItems - shadow_insets.right() /* right */));
animator_.AddObserver(this);
}
@@ -287,8 +286,7 @@ void MessageListView::DoUpdateIfPossible() {
int new_height = GetHeightForWidth(child_area.width() + GetInsets().width());
SetSize(gfx::Size(child_area.width() + GetInsets().width(), new_height));
- if (top_down_ ||
- base::CommandLine::ForCurrentProcess()->HasSwitch(
+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableMessageCenterAlwaysScrollUpUponNotificationRemoval))
AnimateNotificationsBelowTarget();
else
« no previous file with comments | « ui/message_center/views/message_list_view.h ('k') | ui/message_center/views/message_list_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698