Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2558043002: Remove invalid check (Closed)

Created:
4 years ago by clamy
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Remove invalid check Following https://codereview.chromium.org/2392283005, WebContentsObserver::ReadyToCommitNavigation is called outside of PlzNavigate. This CL removes a CHECK(IsBrowserSideNavigationEnabled()) in one of the functions called by an implementation of ReadyToCommitNavigation, since we can now reach it when browser-side navigation is not enabled. BUG=658132 Review-Url: https://codereview.chromium.org/2504973002 Cr-Commit-Position: refs/heads/master@{#433591} (cherry picked from commit 4c429f9b2a054e4d8b26e4a907c1f3c04ca730a1) Committed: https://chromium.googlesource.com/chromium/src/+/bba81655761aeb01fbf3b17ea5283b894d40e1d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M extensions/browser/app_window/app_window.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
clamy
4 years ago (2016-12-07 14:27:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bba81655761aeb01fbf3b17ea5283b894d40e1d2.

Powered by Google App Engine
This is Rietveld 408576698