Remove invalid check

Remove invalid check

Following https://codereview.chromium.org/2392283005,
WebContentsObserver::ReadyToCommitNavigation is called outside of
PlzNavigate. This CL removes a CHECK(IsBrowserSideNavigationEnabled())
in one of the functions called by an implementation of
ReadyToCommitNavigation, since we can now reach it when browser-side
navigation is not enabled.

BUG=658132
Committed: https://crrev.com/4c429f9b2a054e4d8b26e4a907c1f3c04ca730a1
Cr-Commit-Position: refs/heads/master@{#433591}

[clamy, 2016-11-16 12:27:10]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 12:27:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 12:39:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 12:39:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[clamy, 2016-11-16 12:43:38]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 12:43:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[clamy, 2016-11-16 16:12:11]

Description was changed from

==========
Remove invalid check

Following https://codereview.chromium.org/2392283005,
WebContentsObserver::ReadyToCommitNavigation is called outside of
PlzNavigate. This CL removes a CHECK(IsBrowserSideNavigationEnabled())
in one of the functions called by an implementation of
ReadyToCommitNavigation, since we can now reach it when browser-side
navigation is not enabled.

BUG=658132
==========

to

==========
Remove invalid check

Following https://codereview.chromium.org/2392283005,
WebContentsObserver::ReadyToCommitNavigation is called outside of
PlzNavigate. This CL removes a CHECK(IsBrowserSideNavigationEnabled())
in one of the functions called by an implementation of
ReadyToCommitNavigation, since we can now reach it when browser-side
navigation is not enabled.

BUG=658132
==========

[clamy, 2016-11-16 16:12:11]

clamy@chromium.org changed reviewers:
+ rdcronin@google.com

[clamy, 2016-11-16 16:12:40]

clamy@chromium.org changed reviewers:
- rdcronin@google.com

[clamy, 2016-11-16 16:13:09]

clamy@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[clamy, 2016-11-16 16:13:29]

@devlin: PTAL

[Devlin, 2016-11-16 16:17:14]

https://codereview.chromium.org/2504973002/diff/20001/extensions/browser/app_...
File extensions/browser/app_window/app_window.cc (right):

https://codereview.chromium.org/2504973002/diff/20001/extensions/browser/app_...
extensions/browser/app_window/app_window.cc:487: if
(!content::IsBrowserSideNavigationEnabled())
Can we add a comment for why we only perform the work below
(WindowEventsReady(), calling on_first_commit_callback_) from here in the case
of plz navigate?

[commit-bot: I haz the power, 2016-11-16 16:46:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 16:46:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[clamy, 2016-11-17 14:07:29]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[clamy, 2016-11-17 14:07:41]

Thanks!

https://codereview.chromium.org/2504973002/diff/20001/extensions/browser/app_...
File extensions/browser/app_window/app_window.cc (right):

https://codereview.chromium.org/2504973002/diff/20001/extensions/browser/app_...
extensions/browser/app_window/app_window.cc:487: if
(!content::IsBrowserSideNavigationEnabled())
On 2016/11/16 16:17:14, Devlin wrote:
> Can we add a comment for why we only perform the work below
> (WindowEventsReady(), calling on_first_commit_callback_) from here in the case
> of plz navigate?

Done.

[commit-bot: I haz the power, 2016-11-17 14:07:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 15:14:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 15:14:29]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-11-17 15:51:19]

lgtm

https://codereview.chromium.org/2504973002/diff/40001/extensions/browser/app_...
File extensions/browser/app_window/app_window.cc (right):

https://codereview.chromium.org/2504973002/diff/40001/extensions/browser/app_...
extensions/browser/app_window/app_window.cc:491: // process assigned to the
navigation. In the current architecture, this would
optional nit: phrasing like "current architecture" is sometimes asking to become
obsolete :)  Can we describe this as "With renderer-side navigation", or
similar?

[clamy, 2016-11-21 16:05:10]

Thanks!

https://codereview.chromium.org/2504973002/diff/40001/extensions/browser/app_...
File extensions/browser/app_window/app_window.cc (right):

https://codereview.chromium.org/2504973002/diff/40001/extensions/browser/app_...
extensions/browser/app_window/app_window.cc:491: // process assigned to the
navigation. In the current architecture, this would
On 2016/11/17 15:51:19, Devlin wrote:
> optional nit: phrasing like "current architecture" is sometimes asking to
become
> obsolete :)  Can we describe this as "With renderer-side navigation", or
> similar?

Done.

[clamy, 2016-11-21 16:05:13]

The CQ bit was checked by clamy@chromium.org

[clamy, 2016-11-21 16:05:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2504973002/#ps60001
(title: "Addressed comments + rebase")

[commit-bot: I haz the power, 2016-11-21 16:05:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 18:29:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479744313641740,
"parent_rev": "834d465fa465c656714fcc7e44fda61b7927c520", "commit_rev":
"07e170e4a3f33fa155cf9ed670b5a31401054d15"}

[commit-bot: I haz the power, 2016-11-21 18:30:22]

Description was changed from

==========
Remove invalid check

Following https://codereview.chromium.org/2392283005,
WebContentsObserver::ReadyToCommitNavigation is called outside of
PlzNavigate. This CL removes a CHECK(IsBrowserSideNavigationEnabled())
in one of the functions called by an implementation of
ReadyToCommitNavigation, since we can now reach it when browser-side
navigation is not enabled.

BUG=658132
==========

to

==========
Remove invalid check

Following https://codereview.chromium.org/2392283005,
WebContentsObserver::ReadyToCommitNavigation is called outside of
PlzNavigate. This CL removes a CHECK(IsBrowserSideNavigationEnabled())
in one of the functions called by an implementation of
ReadyToCommitNavigation, since we can now reach it when browser-side
navigation is not enabled.

BUG=658132
==========

[commit-bot: I haz the power, 2016-11-21 18:30:23]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-21 18:32:21]

Description was changed from

==========
Remove invalid check

Following https://codereview.chromium.org/2392283005,
WebContentsObserver::ReadyToCommitNavigation is called outside of
PlzNavigate. This CL removes a CHECK(IsBrowserSideNavigationEnabled())
in one of the functions called by an implementation of
ReadyToCommitNavigation, since we can now reach it when browser-side
navigation is not enabled.

BUG=658132
==========

to

==========
Remove invalid check

Following https://codereview.chromium.org/2392283005,
WebContentsObserver::ReadyToCommitNavigation is called outside of
PlzNavigate. This CL removes a CHECK(IsBrowserSideNavigationEnabled())
in one of the functions called by an implementation of
ReadyToCommitNavigation, since we can now reach it when browser-side
navigation is not enabled.

BUG=658132

Committed: https://crrev.com/4c429f9b2a054e4d8b26e4a907c1f3c04ca730a1
Cr-Commit-Position: refs/heads/master@{#433591}
==========

[commit-bot: I haz the power, 2016-11-21 18:32:22]

Patchset 4 (id:??) landed as
https://crrev.com/4c429f9b2a054e4d8b26e4a907c1f3c04ca730a1
Cr-Commit-Position: refs/heads/master@{#433591}